Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Add token as a parameter #237

Merged
merged 1 commit into from Oct 19, 2021
Merged

Conversation

robinbowes
Copy link
Contributor

@robinbowes robinbowes commented Oct 5, 2021

I'm not sure what token is, but it seems wrong to read it from the environment in the make_webook_request function.

This change makes token a parameter, which is passed into post_to_webhook.

Would it be possible for documentation to be added for token?

@google-cla
Copy link

google-cla bot commented Oct 5, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 5, 2021
@robinbowes
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 5, 2021
Copy link
Collaborator

@davidstanke davidstanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call -- the code feels cleaner this way and I've confirmed that it works. LGTM, thanks!

@davidstanke davidstanke merged commit 162e5a6 into dora-team:main Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants