chore: run buildpack tests on pull #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenneth-rosario
force-pushed
the
kennethrosario/run-buildpack-test-on-pull
branch
13 times, most recently
from
344b0c4
to
4b05773
Compare
kenneth-rosario
force-pushed
the
kennethrosario/run-buildpack-test-on-pull
branch
from
4b05773
to
52946d7
Compare
kenneth-rosario
added
the
blunderbuss: assign
blunderbuss-gcf
bot
removed
the
blunderbuss: assign
HKWinterhalter
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
Nice! I noticed in GoogleCloudPlatform/functions-framework-go#208 that you needed to split the CI run into two workflows, do we need the same here?
|
No, in this case the if statement should make this valid on push since it just needs the current branch name. In go the commit sha had to be from the head for go mod cli to be able to find it, thats why I split it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.