Check in synth.py and conform to google node repo standards #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GoogleCloudPlatform/node-team - need help enabling Circle for this one :) |
|
Need to add the docs directory to the .gitignore :) |
JustinBeckwith
approved these changes
Aug 1, 2018
|
@kinwa91 do you have all the rights you need to modify the CircleCI env vars and stuff? |
|
Yup. I will put in the good stuff. :) |
|
Do tests in this repo call the actual service? @stephenplusplus |
|
Yes, they do. There aren't many traditional unit tests-- the testing was mainly done using the actual service. |
|
Got it. I'll start a thread to move those to system-test and rewrite some unit tests. |
JustinBeckwith
approved these changes
Aug 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11