Limit batch deletes to 100 #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| @@ -1398,7 +1398,8 @@ private static void checkContentType(BlobInfo blobInfo) throws IllegalArgumentEx | |||
| byte[] readAllBytes(BlobId blob, BlobSourceOption... options); | |||
|
|
|||
| /** | |||
| * Send a batch request. | |||
| * Send a batch request. If the {@code batchRequest} parameter contains more than 100 deletes the | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks good. One comment about the javadoc and the visibility of this chunking and another style suggestion. |
mziccard
force-pushed
the
limit-batch-deletes
branch
from
2d825de
to
78f8f28
Compare
|
Fixed in place |
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jun 29, 2022
…lti release branch changes (googleapis#401) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/c9932129-4468-4dcc-8cc0-65ca976ea4b5/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@0b064d7
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
* chore: add codeowners * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 20, 2022
Source-Link: googleapis/synthtool@7336562 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:d4b80feffe1579818cdc39466152e9de95789a193408506cd4a1ffbe8804dc00
github-actions bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
🤖 I have created a release *beep* *boop* --- ## [1.1.2](googleapis/java-notebooks@v1.1.1...v1.1.2) (2022-07-29) ### Bug Fixes * enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-notebooks/issues/1485)) ([#401](googleapis/java-notebooks#401)) ([494058f](googleapis/java-notebooks@494058f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
🤖 I have created a release *beep* *boop* --- ## [1.4.4](https://togithub.com/googleapis/java-accesscontextmanager/compare/v1.4.3...v1.4.4) (2022-10-03) ### Dependencies * Update dependency cachetools to v5 ([#401](https://togithub.com/googleapis/java-accesscontextmanager/issues/401)) ([5b95e04](https://togithub.com/googleapis/java-accesscontextmanager/commit/5b95e0409186acc96326cb1419749d1968d09747)) * Update dependency certifi to v2022.9.24 ([#381](https://togithub.com/googleapis/java-accesscontextmanager/issues/381)) ([2006334](https://togithub.com/googleapis/java-accesscontextmanager/commit/20063345f9b41bf9d1f8dad3c8ee5b01e3128b7c)) * Update dependency charset-normalizer to v2.1.1 ([#385](https://togithub.com/googleapis/java-accesscontextmanager/issues/385)) ([a91ee95](https://togithub.com/googleapis/java-accesscontextmanager/commit/a91ee95a4d9aa0d803e410484a2ef0bf55bef5f1)) * Update dependency click to v8.1.3 ([#386](https://togithub.com/googleapis/java-accesscontextmanager/issues/386)) ([703e69c](https://togithub.com/googleapis/java-accesscontextmanager/commit/703e69c8ea5fc2e871ee846c85558f8bcf831ae7)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#405](https://togithub.com/googleapis/java-accesscontextmanager/issues/405)) ([aa35e73](https://togithub.com/googleapis/java-accesscontextmanager/commit/aa35e73690f828d7dfe830b381a83da782650e71)) * Update dependency gcp-releasetool to v1.8.8 ([#382](https://togithub.com/googleapis/java-accesscontextmanager/issues/382)) ([f6c2f5f](https://togithub.com/googleapis/java-accesscontextmanager/commit/f6c2f5f3052b17cb553c765a2285e946bcc22889)) * Update dependency google-api-core to v2.10.1 ([#387](https://togithub.com/googleapis/java-accesscontextmanager/issues/387)) ([9040055](https://togithub.com/googleapis/java-accesscontextmanager/commit/9040055d0f96b7bf3567e4bac4010364d0058eae)) * Update dependency google-auth to v2.12.0 ([#388](https://togithub.com/googleapis/java-accesscontextmanager/issues/388)) ([6d3241c](https://togithub.com/googleapis/java-accesscontextmanager/commit/6d3241cadcfc5ac81232ae495b5207add8d9f59d)) * Update dependency google-cloud-core to v2.3.2 ([#383](https://togithub.com/googleapis/java-accesscontextmanager/issues/383)) ([d3fe01b](https://togithub.com/googleapis/java-accesscontextmanager/commit/d3fe01bc618ffe0e826c052583714524cd049928)) * Update dependency google-cloud-storage to v2.5.0 ([#389](https://togithub.com/googleapis/java-accesscontextmanager/issues/389)) ([934a05e](https://togithub.com/googleapis/java-accesscontextmanager/commit/934a05e263d1bb8b1c94d2f478bf2f15723bd6f8)) * Update dependency google-crc32c to v1.5.0 ([#390](https://togithub.com/googleapis/java-accesscontextmanager/issues/390)) ([5268cb1](https://togithub.com/googleapis/java-accesscontextmanager/commit/5268cb1a04fd9e05d950d5c03871a81e60364d2a)) * Update dependency googleapis-common-protos to v1.56.4 ([#384](https://togithub.com/googleapis/java-accesscontextmanager/issues/384)) ([32b231e](https://togithub.com/googleapis/java-accesscontextmanager/commit/32b231eef7879a6a0d74b650df878e2c462f207e)) * Update dependency importlib-metadata to v4.12.0 ([#391](https://togithub.com/googleapis/java-accesscontextmanager/issues/391)) ([3fee2e5](https://togithub.com/googleapis/java-accesscontextmanager/commit/3fee2e55869b14014c2240ce78a60c5888c7e9ae)) * Update dependency jeepney to v0.8.0 ([#392](https://togithub.com/googleapis/java-accesscontextmanager/issues/392)) ([b8a3a7f](https://togithub.com/googleapis/java-accesscontextmanager/commit/b8a3a7f6fcb6b72f95241a6e8d6b1a152c5e59b9)) * Update dependency jinja2 to v3.1.2 ([#393](https://togithub.com/googleapis/java-accesscontextmanager/issues/393)) ([47bfa73](https://togithub.com/googleapis/java-accesscontextmanager/commit/47bfa73b387eccb7450b8e0f2a19a38bf28d49f3)) * Update dependency keyring to v23.9.3 ([#394](https://togithub.com/googleapis/java-accesscontextmanager/issues/394)) ([1f01a1b](https://togithub.com/googleapis/java-accesscontextmanager/commit/1f01a1b83e4cd45bc03458ae9629e4cbe4c8deec)) * Update dependency markupsafe to v2.1.1 ([#395](https://togithub.com/googleapis/java-accesscontextmanager/issues/395)) ([7077e38](https://togithub.com/googleapis/java-accesscontextmanager/commit/7077e38a1a6c87d3449e63ce89ce3a56d696a93f)) * Update dependency protobuf to v3.20.2 ([#396](https://togithub.com/googleapis/java-accesscontextmanager/issues/396)) ([d5df519](https://togithub.com/googleapis/java-accesscontextmanager/commit/d5df519d69768a54fd02fee3251ed3fc4d9cd9b3)) * Update dependency protobuf to v4 ([#402](https://togithub.com/googleapis/java-accesscontextmanager/issues/402)) ([fe4ac2f](https://togithub.com/googleapis/java-accesscontextmanager/commit/fe4ac2f28d55d887d8618d420df310645ca29046)) * Update dependency pyjwt to v2.5.0 ([#397](https://togithub.com/googleapis/java-accesscontextmanager/issues/397)) ([dd3fa88](https://togithub.com/googleapis/java-accesscontextmanager/commit/dd3fa88e32f6b0b4abc8be4eacfd509b83bd9671)) * Update dependency requests to v2.28.1 ([#398](https://togithub.com/googleapis/java-accesscontextmanager/issues/398)) ([3e55397](https://togithub.com/googleapis/java-accesscontextmanager/commit/3e55397a817d3937b2f50bb7245eda5319d29ae6)) * Update dependency typing-extensions to v4.3.0 ([#399](https://togithub.com/googleapis/java-accesscontextmanager/issues/399)) ([d0d77e2](https://togithub.com/googleapis/java-accesscontextmanager/commit/d0d77e24179689351ddf677b012c14f94e109346)) * Update dependency zipp to v3.8.1 ([#400](https://togithub.com/googleapis/java-accesscontextmanager/issues/400)) ([c40c50e](https://togithub.com/googleapis/java-accesscontextmanager/commit/c40c50edb7767e444cf7a158df513f15e7e6f644)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
🤖 I have created a release *beep* *boop* --- ## [1.2.4](https://togithub.com/googleapis/java-video-transcoder/compare/v1.2.3...v1.2.4) (2022-10-03) ### Dependencies * Update dependency cachetools to v5 ([#396](https://togithub.com/googleapis/java-video-transcoder/issues/396)) ([6826f48](https://togithub.com/googleapis/java-video-transcoder/commit/6826f48fe30ac33ea210b6f3844eb39a4c08dfb3)) * Update dependency certifi to v2022.9.24 ([#399](https://togithub.com/googleapis/java-video-transcoder/issues/399)) ([2ff8fc2](https://togithub.com/googleapis/java-video-transcoder/commit/2ff8fc2e457ce0d70421a0a763ed7f1795b0d5c3)) * Update dependency charset-normalizer to v2.1.1 ([#406](https://togithub.com/googleapis/java-video-transcoder/issues/406)) ([3cfd4d8](https://togithub.com/googleapis/java-video-transcoder/commit/3cfd4d8ba251ae17428882ed887a283cc358be23)) * Update dependency click to v8.1.3 ([#407](https://togithub.com/googleapis/java-video-transcoder/issues/407)) ([eeb397b](https://togithub.com/googleapis/java-video-transcoder/commit/eeb397b53d3ed4e38bc0e381b62125f5dacbefcb)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#410](https://togithub.com/googleapis/java-video-transcoder/issues/410)) ([b319375](https://togithub.com/googleapis/java-video-transcoder/commit/b319375ca8a07f6a681e04f571715ee37f03712a)) * Update dependency gcp-releasetool to v1.8.8 ([#400](https://togithub.com/googleapis/java-video-transcoder/issues/400)) ([d66b716](https://togithub.com/googleapis/java-video-transcoder/commit/d66b716b73d66ea655c44f06821a499fef6ad91c)) * Update dependency google-api-core to v2.10.1 ([#408](https://togithub.com/googleapis/java-video-transcoder/issues/408)) ([8ea31fb](https://togithub.com/googleapis/java-video-transcoder/commit/8ea31fb9f2ccbf612941449aa19961e335be2b96)) * Update dependency google-auth to v2.12.0 ([#403](https://togithub.com/googleapis/java-video-transcoder/issues/403)) ([6e7bd11](https://togithub.com/googleapis/java-video-transcoder/commit/6e7bd116e902461a38c6b92acb2d147b0176667f)) * Update dependency google-cloud-core to v2.3.2 ([#401](https://togithub.com/googleapis/java-video-transcoder/issues/401)) ([0839bdf](https://togithub.com/googleapis/java-video-transcoder/commit/0839bdf2f5dedbeafb52bce10015290a34f8d588)) * Update dependency google-cloud-storage to v2.5.0 ([#404](https://togithub.com/googleapis/java-video-transcoder/issues/404)) ([e5354b1](https://togithub.com/googleapis/java-video-transcoder/commit/e5354b1b3e201599f9d25072642b035ad4827436)) * Update dependency google-crc32c to v1.5.0 ([#405](https://togithub.com/googleapis/java-video-transcoder/issues/405)) ([70eddf4](https://togithub.com/googleapis/java-video-transcoder/commit/70eddf4cb47be66fc9f4e37dde4778046b185bec)) * Update dependency googleapis-common-protos to v1.56.4 ([#402](https://togithub.com/googleapis/java-video-transcoder/issues/402)) ([885959d](https://togithub.com/googleapis/java-video-transcoder/commit/885959df05d9b0f3b96629d26739146efe554912)) * Update dependency importlib-metadata to v4.12.0 ([#386](https://togithub.com/googleapis/java-video-transcoder/issues/386)) ([2ff1f54](https://togithub.com/googleapis/java-video-transcoder/commit/2ff1f54fffd73d513f52319e3311fce025c12819)) * Update dependency jeepney to v0.8.0 ([#387](https://togithub.com/googleapis/java-video-transcoder/issues/387)) ([00d7b43](https://togithub.com/googleapis/java-video-transcoder/commit/00d7b43bf02e8c37288d20f5e850120df711718b)) * Update dependency keyring to v23.9.3 ([#389](https://togithub.com/googleapis/java-video-transcoder/issues/389)) ([a11c743](https://togithub.com/googleapis/java-video-transcoder/commit/a11c7431108d42a8d5f3601a198def5536e267c5)) * Update dependency markupsafe to v2.1.1 ([#390](https://togithub.com/googleapis/java-video-transcoder/issues/390)) ([1f1477b](https://togithub.com/googleapis/java-video-transcoder/commit/1f1477b2803208023f79c23d9663bbeb4e9174f9)) * Update dependency protobuf to v3.20.2 ([#391](https://togithub.com/googleapis/java-video-transcoder/issues/391)) ([3de3e1f](https://togithub.com/googleapis/java-video-transcoder/commit/3de3e1faba25e08eaeff7b0b2766329e0958b8bb)) * Update dependency pyjwt to v2.5.0 ([#392](https://togithub.com/googleapis/java-video-transcoder/issues/392)) ([0eb29ab](https://togithub.com/googleapis/java-video-transcoder/commit/0eb29ab88daabb70591516a35334c04502523852)) * Update dependency typing-extensions to v4.3.0 ([#394](https://togithub.com/googleapis/java-video-transcoder/issues/394)) ([a347428](https://togithub.com/googleapis/java-video-transcoder/commit/a347428b6690ef71238f063e25756b73fad6af42)) * Update dependency zipp to v3.8.1 ([#395](https://togithub.com/googleapis/java-video-transcoder/issues/395)) ([f38182c](https://togithub.com/googleapis/java-video-transcoder/commit/f38182c236224fa36037516fb63bdaf583966df7)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this pull request
Oct 5, 2022
🤖 I have created a release *beep* *boop* --- ## [2.3.6](https://togithub.com/googleapis/java-orgpolicy/compare/v2.3.5...v2.3.6) (2022-10-05) ### Dependencies * Update dependency certifi to v2022.9.24 ([#396](https://togithub.com/googleapis/java-orgpolicy/issues/396)) ([d6e315e](https://togithub.com/googleapis/java-orgpolicy/commit/d6e315e2b3bbdd475d580ccc9fb47a5cec74dd7c)) * Update dependency charset-normalizer to v2.1.1 ([#399](https://togithub.com/googleapis/java-orgpolicy/issues/399)) ([5a17ba7](https://togithub.com/googleapis/java-orgpolicy/commit/5a17ba76cb3e340c616e13bb111d26ae2db494c6)) * Update dependency click to v8.1.3 ([#400](https://togithub.com/googleapis/java-orgpolicy/issues/400)) ([748cf9c](https://togithub.com/googleapis/java-orgpolicy/commit/748cf9c590345bb5e263bcb7048b33bf56e2009f)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#405](https://togithub.com/googleapis/java-orgpolicy/issues/405)) ([1f1768e](https://togithub.com/googleapis/java-orgpolicy/commit/1f1768e7549e436433db00ff72defa0722475267)) * Update dependency gcp-releasetool to v1.8.8 ([#397](https://togithub.com/googleapis/java-orgpolicy/issues/397)) ([8eb0c36](https://togithub.com/googleapis/java-orgpolicy/commit/8eb0c36761020ffc787de1fdbec01437d15fb592)) * Update dependency google-api-core to v2.10.1 ([#401](https://togithub.com/googleapis/java-orgpolicy/issues/401)) ([b72f9d2](https://togithub.com/googleapis/java-orgpolicy/commit/b72f9d27ec1212dc3acd5b1128efae77bcd21ff7)) * Update dependency google-auth to v2.12.0 ([#402](https://togithub.com/googleapis/java-orgpolicy/issues/402)) ([9bfcfb6](https://togithub.com/googleapis/java-orgpolicy/commit/9bfcfb61471aad457e41ec85066c2a4b1c0be8c1)) * Update dependency google-cloud-storage to v2.5.0 ([#403](https://togithub.com/googleapis/java-orgpolicy/issues/403)) ([50b5d7c](https://togithub.com/googleapis/java-orgpolicy/commit/50b5d7c5309c6ec0cd88d95736bca91e7c049759)) * Update dependency googleapis-common-protos to v1.56.4 ([#398](https://togithub.com/googleapis/java-orgpolicy/issues/398)) ([bf62b87](https://togithub.com/googleapis/java-orgpolicy/commit/bf62b872b3bb90a18f5622a7630d1e259bcc7794)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #365 by sending separate batch requests if deletes are more than 100.