Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct documentation on operation 'complete' #1437

Merged
merged 3 commits into from
Jul 18, 2016
Merged

Correct documentation on operation 'complete' #1437

merged 3 commits into from
Jul 18, 2016

Conversation

Gormartsen
Copy link
Contributor

Relate to #1432

@stephenplusplus My pardon!
operation.on('complete') return metadata only. THere is no err value.

I decided to add link to code where all operations emits described.

Feel free to request updates to this PR. No offence here.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 18, 2016
stephenplusplus
stephenplusplus reviewed Jul 18, 2016
View reviewed changes
README.md
if (!err) {
// Virtual machine created!
}
operation.on('complete', function(metadata) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

coveralls commented Jul 18, 2016 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling f6f720a on Gormartsen:patch-1 into 470fc3d on GoogleCloudPlatform:master.

stephenplusplus
stephenplusplus reviewed Jul 18, 2016
View reviewed changes
README.md
});
});
```

You can read more about opeation events [here](https://github.com/GoogleCloudPlatform/gcloud-node/blob/276c847669470c3639eb78d7d87a09db7a9b5c18/lib/compute/operation.js#L83).

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

stephenplusplus
stephenplusplus reviewed Jul 18, 2016
View reviewed changes
README.md
// Virtual machine created!
}
operation
.on('error', function(err) {})

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

coveralls commented Jul 18, 2016 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 082d68d on Gormartsen:patch-1 into 470fc3d on GoogleCloudPlatform:master.

@stephenplusplus
Copy link
Contributor

Thank you very much! Happy coding! 💻 ☕

@stephenplusplus stephenplusplus merged commit b7a5623 into googleapis:master Jul 18, 2016
This was referenced Jul 11, 2023
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Gormartsen @coveralls @stephenplusplus @googlebot