Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system tests (logging): increase consistency delay #1438

Merged

Conversation

stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus commented Jul 18, 2016

The recent push to master has introduced a new failed build (https://travis-ci.org/GoogleCloudPlatform/gcloud-node/jobs/145544257#L7638). We currently have two tests that will write log entries, then verify they were written properly by calling getEntries. We have a "write consistency delay" of 15 seconds that has worked in the past, but after testing with up to 2 minutes now, the call to getEntries still pulls old data.

This PR removes the delay, and simply checks that the "write entries" call doesn't fail.

@filipjs -- is there any reliable way to write a log entry, then pull it down from getEntries({ orderBy: 'timestamp desc', pageSize: 1 })?

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 18, 2016
@stephenplusplus stephenplusplus added testing api: logging Issues related to the Cloud Logging API. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 18, 2016
@coveralls
Copy link

coveralls commented Jul 18, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 5e80899 on stephenplusplus:spp--logging-test-rm-delay into 0c438e4 on GoogleCloudPlatform:master.

@filipjs
Copy link

filipjs commented Jul 18, 2016

We hit a small bump in our processing pipeline earlier today, probably that's why there were failures.
1 minute should be enough for that kind of test.

@stephenplusplus stephenplusplus changed the title system tests (logging): remove consistency delay system tests (logging): increase consistency delay Jul 18, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 18, 2016
@stephenplusplus
Copy link
Contributor Author

Ah, okay. Thanks for the info. I've updated the tests to allow 60 seconds before validating the entries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants