bigtable: v2 support #1439
bigtable: v2 support #1439
Conversation
callmehiphop
added
don't merge
api: bigtable
googlebot
added
the
cla: yes
|
Changes Unknown when pulling 8e633fa on callmehiphop:bigtable-v2 into * on GoogleCloudPlatform:master*. |
|
ReadRows should get a checkbox. It's the most complicated change in v2. |
|
/cc @lesv @sduskis good call! I've added it (and checked it off!). I just pushed a large change that includes the new APIs and updates to the previously existing ones as well as the usage docs. All that really remains for me is a bit of testing, so whenever you get some spare time if you could take a look, that would be much appreciated! Also @stephenplusplus if you don't mind taking a peak as well, that would be awesome :) |
| CLUSTER.setMetadata({ nodes: 4 }, done); | ||
| }); | ||
|
|
||
| it.skip('should delete a cluster', function(done) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@stephenplusplus I removed all the |
| * table.insert(entries) | ||
| * .on('error', console.error) | ||
| * .on('finish', function() { | ||
| * // Mutations finished running. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| if (isStreamMode) { | ||
| return stream; | ||
| if (!isCallbackMode) { | ||
| ['error', 'finish'].forEach(function(event) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM. Is there anything waiting for me to review / comment on that I may have overlooked? |
|
@stephenplusplus I updated a couple of system tests. I think it should be good to go if it looks good to you. |
|
Excellent work, sir! |
Fixes #1526
Moving Bigtable to v2!
TODOS:
Docs Demo