Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR] Update README for more clarity #1446

Merged
merged 2 commits into from
Jul 22, 2016
Merged

[PR] Update README for more clarity #1446

merged 2 commits into from
Jul 22, 2016

Conversation

commit-master
Copy link
Contributor

Added in comment the other option using credentials instead of keyFilename.
Also added comments to explain the difference between both.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 22, 2016
@commit-master
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 22, 2016
@coveralls
Copy link

coveralls commented Jul 22, 2016 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 3cbcfe4 on commit-master:master into 5689f96 on GoogleCloudPlatform:master.

stephenplusplus
stephenplusplus reviewed Jul 22, 2016
View reviewed changes
README.md
@@ -78,11 +78,19 @@ If you are not running this client on Google Compute Engine, you need a Google D
// Authenticating on a global basis.
var projectId = process.env.GCLOUD_PROJECT; // E.g. 'grape-spaceship-123'

// Using a string of your keyfile.json path
var gcloud = require('gcloud')({
projectId: projectId,
keyFilename: '/path/to/keyfile.json'
});

This comment was marked as spam.

Sign in to view

@stephenplusplus
Copy link
Contributor

Thanks :D

@commit-master
Copy link
Contributor Author

This is my first PR actually ahah. Sounds very good to me ! Way more clear than my attempt.

Thanks !

@stephenplusplus
Copy link
Contributor

Oh that's awesome, thanks for spending it on helping us! I remember my first PR... ah, the good ol' days.

Hey, now you can change your name to pr-master :)

@commit-master
Copy link
Contributor Author

Ahaha thanks ! Appreciate it !
💥 ⚡️ 🎉

@coveralls
Copy link

coveralls commented Jul 22, 2016 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 532f980 on commit-master:master into 5689f96 on GoogleCloudPlatform:master.

@stephenplusplus
Copy link
Contributor

Looks great to me. Thanks again, feel free to send us many more :)

@stephenplusplus stephenplusplus merged commit 86e5fd8 into googleapis:master Jul 22, 2016
@commit-master
Copy link
Contributor Author

Thank you, I feel complete now 🎆

@stephenplusplus
Copy link
Contributor

Hahaha 🌠 💯 🏁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@commit-master @googlebot @coveralls @stephenplusplus