Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to pubsub API to v1 #957

Closed
dhermes opened this issue Jul 1, 2015 · 2 comments
Closed

Migrate to pubsub API to v1 #957

dhermes opened this issue Jul 1, 2015 · 2 comments
Assignees
@dhermes
Labels
api: pubsub Issues related to the Pub/Sub API.

Comments

@dhermes
Copy link
Contributor

dhermes commented Jul 1, 2015

See googleapis/google-cloud-node#699
@dhermes dhermes added the api: pubsub Issues related to the Pub/Sub API. label Jul 1, 2015
@dhermes
Copy link
Contributor Author

dhermes commented Jul 14, 2015

Fixed in googleapis/google-cloud-node#711

@dhermes
Copy link
Contributor Author

dhermes commented Jul 14, 2015

Only relevant difference (in discovery docs) between v1beta2 and v1 is

@@ -524,10 +524,6 @@
    "type": "object",
    "description": "Request for the ModifyAckDeadline method.",
    "properties": {
-    "ackId": {
-     "type": "string",
-     "description": "The acknowledgment ID. Either this or ack_ids must be populated, but not both."
-    },
     "ackIds": {
      "type": "array",
      "description": "List of acknowledgment IDs.",

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jul 14, 2015
@dhermes
Upgrading pubsub to v1.
e067635 
Fixes googleapis#957.
@dhermes dhermes mentioned this issue Jul 14, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhermes dhermes

Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dhermes