Select API helper based on presence of grpcio + optional environment marker #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tseaver
added
do not merge
googlebot
added
the
cla: yes
|
I'm fine with the overall approach. As usual, I'm anti-"lazy loading approach". I'd also like to see us try to unify the APIs that use gRPC a little bit (doesn't need to happen here, just want to keep an eye on it). |
If present, prefer the GAX helper, but allow disabling it via an environment marker.
tseaver
removed
the
do not merge
|
Issue #1857 tracks the question of lazy-loading the API helpers. |
|
@daspecster PTAL |
|
@tseaver LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not yet ready to merge, as the system tests will break until new versions of
grpcioandgoogle-gax-pubusb-v1are released (see #1814).@dhermes PTAL at the overall approach to choosing gRPC vs. JSON-over-HTTP.