Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache-Control metadata cleared on save #648

Closed
gkresic opened this issue Apr 6, 2022 · 6 comments
Closed

Cache-Control metadata cleared on save #648

gkresic opened this issue Apr 6, 2022 · 6 comments

Comments

@gkresic
Copy link

gkresic commented Apr 6, 2022

I have a file in bucket that has Cache-Control set to no-store in metadata.

If I mount this bucket using gcsfuse (version 0.40.0), modify a file and save it, file's Cache-Control metadata is cleared/unset.

@avidullu avidullu added the feature request Feature request: request to add new features or functionality label Apr 14, 2022
@vadlakondaswetha
Copy link
Collaborator

Can you tell how are you modifying the file. Is it via editors like vi/vim or programatically?

@gkresic
Copy link
Author

gkresic commented Apr 20, 2022

Using IntelliJ.

@vadlakondaswetha
Copy link
Collaborator

The issue is fixed at head. The object properties will be retained if the edit is done programmatically. Incase the edit is done via editors like vi/vim, the properties will not be retained since vi/vim deletes the original file and creates a new file. GcsFuse has no control over this behaviour.

@gkresic, For intellij, the original file is not deleted, hence the object properties will get retained. We will soon do a release. Meanwhile, you can try installing gcsfuse from source.

@avidullu
Copy link
Contributor

Please retry with the latest release (0.41) of gcsfuse which has a fix for the same.

@gkresic
Copy link
Author

gkresic commented Apr 28, 2022

I can confirm that version 0.41.0 works OK, at least when file is edited via IntelliJ.

@avidullu
Copy link
Contributor

Thanks for the confirmation. Will close this issue out. Please feel free to reopen incase you find any inconsistencies.
Thanks for the help in resolving this!

@avidullu avidullu removed the feature request Feature request: request to add new features or functionality label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants