Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Incorrect path to worker in task sample code #360

Closed
JohannRosenberg opened this issue Feb 7, 2018 · 1 comment · Fixed by GoogleCloudPlatform/java-docs-samples#2444
Labels
api: appengine Issues related to the App Engine Admin API API. good first issue This issue is a good place to started contributing to this repository. priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@JohannRosenberg
Copy link

In the sample code located at:

https://github.com/GoogleCloudPlatform/java-docs-samples/blob/master/appengine-java8/taskqueues-push/src/main/java/com/example/appengine/taskqueue/push/Enqueue.java

line 47. The code shows:

queue.add(TaskOptions.Builder.withUrl("/worker").param("key", key));

The path is incorrect. It should be "/taskqueues/worker":

queue.add(TaskOptions.Builder.withUrl("/taskqueues/worker").param("key", key));

Without this path corrected, the doPost at will not get called in the worker handler:

https://github.com/GoogleCloudPlatform/java-docs-samples/blob/master/appengine-java8/taskqueues-push/src/main/java/com/example/appengine/taskqueue/push/Worker.java

@JohannRosenberg JohannRosenberg changed the title Incorrect path to worker in task sample code Bug: Incorrect path to worker in task sample code Feb 7, 2018
@JustinBeckwith JustinBeckwith added triage me I really want to be triaged. 🚨 This issue needs some love. labels Oct 3, 2019
@dzlier-gcp dzlier-gcp added good first issue This issue is a good place to started contributing to this repository. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed triage me I really want to be triaged. labels Oct 14, 2019
@dzlier-gcp dzlier-gcp self-assigned this Oct 14, 2019
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Oct 14, 2019
@dzlier-gcp dzlier-gcp added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Oct 14, 2019
@dzlier-gcp dzlier-gcp removed the 🚨 This issue needs some love. label Oct 31, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Oct 31, 2019
@JustinBeckwith JustinBeckwith added the api: appengine Issues related to the App Engine Admin API API. label Jan 13, 2020
@dzlier-gcp
Copy link
Member

This bug should be filed in the java-docs-samples repo, but I've opened GoogleCloudPlatform/java-docs-samples#2444 to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: appengine Issues related to the App Engine Admin API API. good first issue This issue is a good place to started contributing to this repository. priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants