New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link Google Cloud Storage from top-level README. #1170
Conversation
Finished the checklist, so we should link the library and documentation from the top-level README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
README.md
Outdated
This library supports the following Google Cloud Platform services with clients | ||
at the [Alpha](#versioning) quality level: | ||
|
||
- [Google Cloud Storage](google/cloud/storage#google-cloud-storage) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For easier reference and easier future copy-pasting, you can just link to #readme
which is a standard built-in tag for the beginning of the README, so you don't need to carefully emulate the actual heading.
If you fix this, consider also fixing the Cloud Bigtable link above similarly. Up to you.
Codecov Report
@@ Coverage Diff @@
## master #1170 +/- ##
======================================
Coverage 92.1% 92.1%
======================================
Files 219 219
Lines 12049 12049
======================================
Hits 11098 11098
Misses 951 951 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit. LGTM.
### 2018-09 | ||
|
||
* The library implements all the APIs in the service, including: | ||
* Create, list, and delete buckets and objects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing: rewrite and compose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please wait until samples are on cloud.google.com/storage/docs/
Finished the checklist, so we should link the library and
documentation from the top-level README.
This change is