Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Google Cloud Storage from top-level README. #1170

Merged
merged 3 commits into from Oct 8, 2018

Conversation

coryan
Copy link
Member

@coryan coryan commented Sep 25, 2018

Finished the checklist, so we should link the library and
documentation from the top-level README.


This change is Reviewable

Finished the checklist, so we should link the library and
documentation from the top-level README.
@coryan coryan added the api: storage Issues related to the Cloud Storage API. label Sep 25, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 25, 2018
Copy link
Contributor

@mbrukman mbrukman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated
This library supports the following Google Cloud Platform services with clients
at the [Alpha](#versioning) quality level:

- [Google Cloud Storage](google/cloud/storage#google-cloud-storage)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For easier reference and easier future copy-pasting, you can just link to #readme which is a standard built-in tag for the beginning of the README, so you don't need to carefully emulate the actual heading.

If you fix this, consider also fixing the Cloud Bigtable link above similarly. Up to you.

@codecov
Copy link

codecov bot commented Sep 25, 2018

Codecov Report

Merging #1170 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1170   +/-   ##
======================================
  Coverage    92.1%   92.1%           
======================================
  Files         219     219           
  Lines       12049   12049           
======================================
  Hits        11098   11098           
  Misses        951     951

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21fd5f6...af22aee. Read the comment docs.

Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit. LGTM.

### 2018-09

* The library implements all the APIs in the service, including:
* Create, list, and delete buckets and objects.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing: rewrite and compose.

Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait until samples are on cloud.google.com/storage/docs/

@coryan coryan merged commit 4d23a09 into googleapis:master Oct 8, 2018
@coryan coryan deleted the link-gcs-library-from-readme branch October 8, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants