Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider autoclosing pull requests #715

Closed
pongad opened this issue Aug 2, 2017 · 4 comments
Closed

consider autoclosing pull requests #715

pongad opened this issue Aug 2, 2017 · 4 comments
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@pongad
Copy link
Contributor

pongad commented Aug 2, 2017

This repo uses gerrit so we can't accept github PRs. We should consider a bot to close PRs and providing instructions on how to use gerrit to contribute. The Go repo already has this so there's some precedence.

@jba, I'm not sure if this is appropriate for fixit; please feel free to remove the milestone.

@pongad pongad added this to the Fixit 2017 Q3 milestone Aug 2, 2017
@s-mang
Copy link

s-mang commented Aug 2, 2017

a big fat

+1

@rakyll
Copy link
Contributor

rakyll commented Aug 3, 2017

I have a CL waiting for this at https://code-review.googlesource.com/c/11596.

@pongad
Copy link
Contributor Author

pongad commented Aug 4, 2017

@rakyll Nice! I didn't know about this. I don't think there is an issue tracking this, so I'm inclined to leave this here for now and close when the CL is merged. Feel free to close if you disagree though.

@pongad pongad added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Aug 8, 2017
@jba jba removed this from the Fixit 2017 Q3 milestone Aug 8, 2017
@rakyll rakyll self-assigned this Aug 9, 2017
@jba jba unassigned rakyll Dec 15, 2017
@jba
Copy link
Contributor

jba commented Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants