Add of() method to DatasetInfo (#1275)

googleapis · Sep 21, 2016 · 05a2a32 · 05a2a32
1 parent 062600a
commit 05a2a32
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 0 deletions.
diff --git a/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/DatasetInfo.java b/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/DatasetInfo.java
@@ -460,6 +460,20 @@ public static Builder builder(String datasetId) {
     return builder(DatasetId.of(datasetId));
   }
 
+  /**
+   * Returns a {@code DatasetInfo} object given it's identity.
+   */
+  public static DatasetInfo of(DatasetId datasetId) {
+    return builder(datasetId).build();
+  }
+
+  /**
+   * Returns a {@code DatasetInfo} object given it's user-defined id.
+   */
+  public static DatasetInfo of(String datasetId) {
+    return builder(datasetId).build();
+  }
+
   /**
    * Returns a builder for the DatasetInfo object given it's user-defined project and dataset ids.
    */

diff --git a/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/DatasetInfoTest.java b/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/DatasetInfoTest.java
@@ -107,6 +107,34 @@ public void testBuilder() {
     assertEquals(SELF_LINK, DATASET_INFO_COMPLETE.selfLink());
   }
 
+  @Test
+  public void testOf() {
+    DatasetInfo datasetInfo = DatasetInfo.of(DATASET_ID.dataset());
+    assertEquals(DATASET_ID, datasetInfo.datasetId());
+    assertNull(datasetInfo.acl());
+    assertNull(datasetInfo.creationTime());
+    assertNull(datasetInfo.defaultTableLifetime());
+    assertNull(datasetInfo.description());
+    assertNull(datasetInfo.etag());
+    assertNull(datasetInfo.friendlyName());
+    assertNull(datasetInfo.generatedId());
+    assertNull(datasetInfo.lastModified());
+    assertNull(datasetInfo.location());
+    assertNull(datasetInfo.selfLink());
+    datasetInfo = DatasetInfo.of(DATASET_ID);
+    assertEquals(DATASET_ID, datasetInfo.datasetId());
+    assertNull(datasetInfo.acl());
+    assertNull(datasetInfo.creationTime());
+    assertNull(datasetInfo.defaultTableLifetime());
+    assertNull(datasetInfo.description());
+    assertNull(datasetInfo.etag());
+    assertNull(datasetInfo.friendlyName());
+    assertNull(datasetInfo.generatedId());
+    assertNull(datasetInfo.lastModified());
+    assertNull(datasetInfo.location());
+    assertNull(datasetInfo.selfLink());
+  }
+
   @Test
   public void testToPbAndFromPb() {
     compareDatasets(DATASET_INFO_COMPLETE, DatasetInfo.fromPb(DATASET_INFO_COMPLETE.toPb()));