pr comment

googleapis · Jun 21, 2017 · 3f2f686 · 3f2f686
1 parent bbb9c30
commit 3f2f686
Show file tree

Hide file tree

Showing 14 changed files with 66 additions and 9 deletions.
diff --git a/README.md b/README.md
@@ -835,12 +835,19 @@ Troubleshooting
 
 To get help, follow the instructions in the [shared Troubleshooting document](https://github.com/GoogleCloudPlatform/gcloud-common/blob/master/troubleshooting/readme.md#troubleshooting).
 
-### Proxy (Experimental)
-Many clients in this repository use gRPC, not HTTP.
-In these clients, the `http.proxyHost` property takes no effect.
-To use proxy in gRPC clients, set the `GRPC_PROXY_EXP` environment variable;
-more details are available in the gRPC [release note](https://github.com/grpc/grpc-java/releases/tag/v1.0.3).
-Please note that proxy support is currently experimental.
+Proxy
+-----
+Clients in this repository use either HTTP or gRPC transport layer.
+README of each client documents the transport layer the client uses.
+
+For HTTP clients, proxy can be configured by `http.proxyHost` and
+related system properties as documented by
+[Java Networking and Proxies](https://docs.oracle.com/javase/8/docs/technotes/guides/net/proxies.html).
+
+For gRPC clients, proxy can be configured by the
+`GRPC_PROXY_EXP` environment variable as documented by
+the gRPC [release note](https://github.com/grpc/grpc-java/releases/tag/v1.0.3).
+Please note that the gRPC proxy support is currently experimental.
 
 Java Versions
 -------------
@@ -850,7 +857,7 @@ Java 7 or above is required for using this client.
 Supported Platforms
 -------------------
 
-This client is supported on Mac OS X, Windows and Linux (excluding Android and Alpine). 
+This client is supported on Mac OS X, Windows and Linux (excluding Android and Alpine).
 Google Cloud Platform environments currently supported include GCE, GKE and GAE Flex.
 GAE Standard is not currently supported.
 

diff --git a/google-cloud-bigquery/README.md b/google-cloud-bigquery/README.md
@@ -214,6 +214,10 @@ Troubleshooting
 
 To get help, follow the instructions in the [shared Troubleshooting document](https://github.com/GoogleCloudPlatform/gcloud-common/blob/master/troubleshooting/readme.md#troubleshooting).
 
+Transport
+---------
+BigQuery uses HTTP transport.
+
 Java Versions
 -------------
 

diff --git a/google-cloud-compute/README.md b/google-cloud-compute/README.md
@@ -218,6 +218,10 @@ Troubleshooting
 
 To get help, follow the instructions in the [shared Troubleshooting document](https://github.com/GoogleCloudPlatform/gcloud-common/blob/master/troubleshooting/readme.md#troubleshooting).
 
+Transport
+---------
+Compute uses HTTP transport.
+
 Java Versions
 -------------
 

diff --git a/google-cloud-datastore/README.md b/google-cloud-datastore/README.md
@@ -150,6 +150,10 @@ Troubleshooting
 
 To get help, follow the instructions in the [shared Troubleshooting document](https://github.com/GoogleCloudPlatform/gcloud-common/blob/master/troubleshooting/readme.md#troubleshooting).
 
+Transport
+---------
+Datastore uses HTTP transport.
+
 Java Versions
 -------------
 

diff --git a/google-cloud-dns/README.md b/google-cloud-dns/README.md
@@ -342,6 +342,10 @@ Troubleshooting
 
 To get help, follow the instructions in the [shared Troubleshooting document](https://github.com/GoogleCloudPlatform/gcloud-common/blob/master/troubleshooting/readme.md#troubleshooting).
 
+Transport
+---------
+DNS uses HTTP transport.
+
 Java Versions
 -------------
 

diff --git a/google-cloud-language/README.md b/google-cloud-language/README.md
@@ -63,6 +63,10 @@ Troubleshooting
 
 To get help, follow the instructions in the [shared Troubleshooting document](https://github.com/GoogleCloudPlatform/gcloud-common/blob/master/troubleshooting/readme.md#troubleshooting).
 
+Transport
+---------
+Language uses gRPC transport.
+
 Java Versions
 -------------
 

diff --git a/google-cloud-logging/README.md b/google-cloud-logging/README.md
@@ -164,6 +164,10 @@ and
 we put together all the code shown above into three programs. The programs assume that you are
 running on Compute Engine or from your own desktop.
 
+Transport
+---------
+Logging uses gRPC transport.
+
 Java Versions
 -------------
 

diff --git a/google-cloud-pubsub/README.md b/google-cloud-pubsub/README.md
@@ -201,6 +201,10 @@ and
 we put together all the code shown above into two programs. The programs assume that you are
 running on Compute Engine, App Engine Flexible or from your own desktop.
 
+Transport
+---------
+Pub/Sub uses gRPC transport.
+
 Java Versions
 -------------
 

diff --git a/google-cloud-resourcemanager/README.md b/google-cloud-resourcemanager/README.md
@@ -212,6 +212,10 @@ The third program modifies the IAM policy associated with a project using the re
 pattern.  Complete source code can be found at
 [ModifyPolicy.java](../google-cloud-examples/src/main/java/com/google/cloud/examples/resourcemanager/snippets/ModifyPolicy.java)
 
+Transport
+---------
+Resource Manager uses HTTP transport.
+
 Java Versions
 -------------
 
@@ -252,4 +256,3 @@ Apache 2.0 - See [LICENSE] for more information.
 [cloud-platform]: https://cloud.google.com/
 [cloud-resourcemanager]: https://cloud.google.com/resource-manager/docs
 [resourcemanager-api]: https://googlecloudplatform.github.io/google-cloud-java/apidocs/index.html?com/google/cloud/resourcemanager/package-summary.html
-
diff --git a/google-cloud-spanner/README.md b/google-cloud-spanner/README.md
@@ -70,6 +70,10 @@ started](https://cloud.google.com/spanner/docs/getting-started/java/) guide.
 To get help, follow the instructions in the [shared Troubleshooting
 document](https://github.com/GoogleCloudPlatform/gcloud-common/blob/master/troubleshooting/readme.md#troubleshooting).
 
+Transport
+---------
+Spanner uses gRPC transport.
+
 ## Java Versions
 
 Java 7 or above is required for using this client.

diff --git a/google-cloud-speech/README.md b/google-cloud-speech/README.md
@@ -61,12 +61,15 @@ In [RecognizeSpeech.java](../google-cloud-examples/src/main/java/com/google/clou
 For an example audio file please check the [audio.raw](https://github.com/GoogleCloudPlatform/java-docs-samples/blob/master/speech/cloud-client/resources/audio.raw) from the samples repository.
 Note, to play the file on Unix-like system you may use the following command: `play -t raw -r 16k -e signed -b 16 -c 1 audio.raw`
 
-
 Troubleshooting
 ---------------
 
 To get help, follow the instructions in the [shared Troubleshooting document](https://github.com/GoogleCloudPlatform/gcloud-common/blob/master/troubleshooting/readme.md#troubleshooting).
 
+Transport
+---------
+Speech uses gRPC transport.
+
 Java Versions
 -------------
 

diff --git a/google-cloud-storage/README.md b/google-cloud-storage/README.md
@@ -151,6 +151,10 @@ Troubleshooting
 
 To get help, follow the instructions in the [shared Troubleshooting document](https://github.com/GoogleCloudPlatform/gcloud-common/blob/master/troubleshooting/readme.md#troubleshooting).
 
+Transport
+---------
+Storage uses HTTP transport.
+
 Java Versions
 -------------
 

diff --git a/google-cloud-translate/README.md b/google-cloud-translate/README.md
@@ -149,6 +149,10 @@ Troubleshooting
 
 To get help, follow the instructions in the [shared Troubleshooting document](https://github.com/GoogleCloudPlatform/gcloud-common/blob/master/troubleshooting/readme.md#troubleshooting).
 
+Transport
+---------
+Translate uses HTTP transport.
+
 Java Versions
 -------------
 

diff --git a/google-cloud-vision/README.md b/google-cloud-vision/README.md
@@ -65,6 +65,10 @@ Troubleshooting
 
 To get help, follow the instructions in the [shared Troubleshooting document](https://github.com/GoogleCloudPlatform/gcloud-common/blob/master/troubleshooting/readme.md#troubleshooting).
 
+Transport
+---------
+Vision uses gRPC transport.
+
 Java Versions
 -------------