Remove AuthCredentials and related classes, use google-auth-library-java instead #1375

mziccard · 2016-11-07T12:08:18Z

This PR gets rid of our AuthCredentials classes and uses google-auth-library-java instead.

…ava instead

coveralls · 2016-11-07T17:07:26Z

Coverage increased (+0.3%) to 84.152% when pulling c3d396d on mziccard:refactor-auth into e4fb76b on GoogleCloudPlatform:master.

mziccard · 2016-11-07T17:57:24Z

@lesv @garrettjonesgoogle care to have a look?

lesv

LGTM - but give folks a few hours to respond to my question on the README.

README.md

+
+To access Google Cloud services, you first need to ensure that the necessary Google Cloud APIs are
+enabled for your project. To do this, follow the instructions on the
+[authentication document](https://github.com/GoogleCloudPlatform/gcloud-common/blob/master/authentication/readme.md#authentication)


README.md

-First, ensure that the necessary Google Cloud APIs are enabled for your project. To do this, follow the instructions on the [authentication document](https://github.com/GoogleCloudPlatform/gcloud-common/blob/master/authentication/readme.md#authentication) shared by all the gcloud language libraries.
+`google-cloud-java` uses
+[https://github.com/google/google-auth-library-java](https://github.com/google/google-auth-library-java)
+to authenticate requests. `google-auth-library-java` supports a wide range of authentication types,


README.md

-  * If you already have an OAuth2 access token, you can use it to authenticate (notice that in this case the access token will not be automatically refreshed):
+  * If running locally for development/testing, you can use the
+  [Google Cloud SDK](https://cloud.google.com/sdk/). Create Application Default Credentials with
+  `gcloud auth application-default login`, `google-cloud` will automatically detect such


README.md

+  `gcloud auth application-default login`, `google-cloud` will automatically detect such
+  credentials.
+  * If you already have an OAuth2 access token, you can use it to authenticate (notice that in this
+  case the access token will not be automatically refreshed):


README.md

-3. Key file pointed to by the GOOGLE_APPLICATION_CREDENTIALS environment variable
-4. Google Cloud SDK credentials
-5. Compute Engine credentials
+1. Credentials file pointed to by the `GOOGLE_APPLICATION_CREDENTIALS` environment variable


TESTING.md

@@ -102,7 +102,7 @@ You can test against a remote Datastore emulator as well.  To do this, set the `
  DatastoreOptions options = DatastoreOptions.newBuilder()
      .setProjectId("my-project-id") // must match project ID specified on remote machine
      .setHost("http://<hostname of machine>:<port>")
-      .setAuthCredentials(AuthCredentials.noAuth())
+      .setNoCredentials()


google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/SerializationTest.java

        .build();
    BigQueryOptions otherOptions = options.toBuilder()
        .setProjectId("p2")
-        .setAuthCredentials(null)
+        .setCredentials(null)


google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryOptions.java

@@ -28,7 +28,7 @@

  private static final String BIGQUERY_SCOPE = "https://www.googleapis.com/auth/bigquery";
  private static final Set<String> SCOPES = ImmutableSet.of(BIGQUERY_SCOPE);
-  private static final long serialVersionUID = -8592198255032667206L;
+  private static final long serialVersionUID = -2437598817433266049L;


google-cloud-core/src/main/java/com/google/cloud/ServiceOptions.java

     * @return the builder
+     * @throws NullPointerException if {@code credentials} is {@code null}. To disable
+     *     authentication use {@link Builder#setNoCredentials()}


coveralls · 2016-11-07T23:42:15Z

Coverage increased (+0.2%) to 84.143% when pulling 96c2b60 on mziccard:refactor-auth into e4fb76b on GoogleCloudPlatform:master.

garrettjonesgoogle · 2016-11-08T00:29:32Z

LGTM

coveralls · 2016-11-08T03:39:10Z

Coverage increased (+0.2%) to 84.145% when pulling e8f9f6e on mziccard:refactor-auth into e4fb76b on GoogleCloudPlatform:master.

mziccard added the auth label Nov 7, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 7, 2016

mziccard mentioned this pull request Nov 7, 2016

Expose static methods to get the default project ID and credentials #1241

Closed

Remove AuthCredentials and related classes, use google-auth-library-j…

c3d396d

…ava instead

mziccard force-pushed the refactor-auth branch from e4e1baa to c3d396d Compare November 7, 2016 16:41

lesv approved these changes Nov 7, 2016

View reviewed changes

garrettjonesgoogle reviewed Nov 7, 2016

View reviewed changes

mziccard added 2 commits November 7, 2016 21:28

Throw NPE when setCredentials is called with null

faa4476

Fix wording in main README's Authentication section

96c2b60

garrettjonesgoogle reviewed Nov 7, 2016

View reviewed changes

Add NoCredentials class and remove setNoCredentials method

e8f9f6e

mziccard force-pushed the refactor-auth branch from 85e06c2 to e8f9f6e Compare November 7, 2016 23:52

mziccard merged commit e5f9046 into googleapis:master Nov 8, 2016

This was referenced Nov 9, 2016

Plans to harmonize authentication? #1345

Closed

authCredentials set on DatastoreOptions.builder() is not used so can't access Datastore over http proxy #1210

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove AuthCredentials and related classes, use google-auth-library-java instead #1375

Remove AuthCredentials and related classes, use google-auth-library-java instead #1375

mziccard commented Nov 7, 2016

coveralls commented Nov 7, 2016

mziccard commented Nov 7, 2016

lesv left a comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Nov 7, 2016

garrettjonesgoogle commented Nov 8, 2016

coveralls commented Nov 8, 2016

Remove AuthCredentials and related classes, use google-auth-library-java instead #1375

Remove AuthCredentials and related classes, use google-auth-library-java instead #1375

Conversation

mziccard commented Nov 7, 2016

coveralls commented Nov 7, 2016

mziccard commented Nov 7, 2016

lesv left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Nov 7, 2016

garrettjonesgoogle commented Nov 8, 2016

coveralls commented Nov 8, 2016