Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update constructor args #1045

Merged
merged 12 commits into from May 24, 2018
Merged

Update constructor args #1045

merged 12 commits into from May 24, 2018

Conversation

michaelbausor
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 4, 2018
michaelbausor
michaelbausor commented May 4, 2018
View reviewed changes
BigQueryDataTransfer/src/V1/Gapic/DataTransferServiceGapicClient.php Outdated
* \Google\Auth\FetchAuthTokenInterface object or \Google\ApiCore\CredentialsWrapper
* object. Note that when one of these objects are provided, any settings in
* $credentialsConfig will be ignored.
* @type array $credentialsConfig

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dwsupplee
dwsupplee reviewed May 7, 2018
View reviewed changes
.gitignore Outdated
@@ -9,3 +9,5 @@ vendor/
# do not delete
keys/
.testing

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

BigQueryDataTransfer/src/V1/DataTransferServiceClient.php Outdated
@@ -1,6 +1,6 @@
<?php
/*
* Copyright 2017 Google LLC
* Copyright 2018 Google LLC

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

BigQueryDataTransfer/src/V1/Gapic/DataTransferServiceGapicClient.php Outdated
* The transport used for executing network requests. May be either the string `rest`
* or `grpc`. Defaults to `grpc` if gRPC support is detected on the system.
* *Advanced usage*: Additionally, it is possible to pass in an already instantiated
* TransportInterface object. Note that when this objects is provided, any settings in

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

BigQueryDataTransfer/src/V1/Gapic/DataTransferServiceGapicClient.php Outdated
* 'grpc' => [...],
* 'rest' => [...]
* ];
* See the GrpcTransport::build and RestTransport::build methods for the supported

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@michaelbausor michaelbausor changed the title DO NOT MERGE: Update constructor args Update constructor args May 18, 2018
@michaelbausor
Copy link
Contributor Author

This is ready for final review before being merged, PTAL

dwsupplee
dwsupplee reviewed May 21, 2018
View reviewed changes
Copy link
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great

Bigtable/src/Admin/V2/Gapic/BigtableInstanceAdminGapicClient.php Outdated
'restClientConfigPath' => __DIR__.'/../resources/bigtable_instance_admin_rest_client_config.php',
],
],
'versionFile' => __DIR__.'/../../../VERSION',

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Bigtable/src/Admin/V2/Gapic/BigtableInstanceAdminGapicClient.php Outdated
$requestParams = new RequestParamsHeaderDescriptor([
'parent' => $request->getParent(),
]);
$optionalArgs['userHeaders'] = isset($optionalArgs['userHeaders'])

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dwsupplee
dwsupplee reviewed May 21, 2018
View reviewed changes
Bigtable/src/Admin/V2/Gapic/BigtableTableAdminGapicClient.php Outdated
'restClientConfigPath' => __DIR__.'/../resources/bigtable_table_admin_rest_client_config.php',
],
],
'versionFile' => __DIR__.'/../../../VERSION',

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dwsupplee dwsupplee mentioned this pull request May 22, 2018
Closed
@chingor13 chingor13 mentioned this pull request May 23, 2018
Merged
@dwsupplee dwsupplee merged commit ce8c1e1 into googleapis:master May 24, 2018
@dwsupplee dwsupplee mentioned this pull request May 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwsupplee dwsupplee dwsupplee approved these changes

@chingor13 chingor13 Awaiting requested review from chingor13

@jdpedrie jdpedrie Awaiting requested review from jdpedrie

@tmatsuo tmatsuo Awaiting requested review from tmatsuo

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michaelbausor @dwsupplee @googlebot