Preserve ACL when copying or renaming blob. #2409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tseaver
suggested changes
Sep 23, 2016
| @@ -440,7 +440,7 @@ def delete_blobs(self, blobs, on_error=None, client=None): | |||
| raise | |||
|
|
|||
| def copy_blob(self, blob, destination_bucket, new_name=None, | |||
| client=None): | |||
| client=None, preserve_acl=False): | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| return new_blob | ||
|
|
||
| def rename_blob(self, blob, new_name, client=None): | ||
| def rename_blob(self, blob, new_name, client=None, preserve_acl=False): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tseaver
reviewed
Sep 26, 2016
| self.assertIs(new_blob.bucket, dest) | ||
| self.assertEqual(new_blob.name, NEW_NAME) | ||
| self.assertIsInstance(new_blob.acl, ObjectACL) | ||
| self.assertFalse(new_blob.acl.loaded) | ||
| self.assertEqual(new_blob.acl.entities, {}) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
daspecster
force-pushed
the
add-storage-preserve-acl
branch
from
8e85462
to
04ea4f7
Compare
|
I finally circled back around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #2389
ACL settings are not held when copying a blob or renaming a blob.
Adds
preserve_acltoBucket.copy_blobandBucket.rename_blob.