Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move dns code into a subpackage #2428

Merged
merged 2 commits into from Sep 26, 2016
Merged

Move dns code into a subpackage #2428

merged 2 commits into from Sep 26, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 26, 2016

This PR was created via: https://gist.github.com/dhermes/e239691aa584bd56a5352e34aad27cf3

export PROJECT_DIR="${HOME}/google-cloud-python"
export READMES_DIR="${HOME}/i-wrote-some-readmes-for-2357"
cd ${PROJECT_DIR}
git worktree add -b make-dns-subpackage ../hotfix official/master
python make_commits.py \
  --git-root "${PROJECT_DIR}/../hotfix" \
  --package dns \
  --package-name "Google Cloud DNS" \
  --readme "${READMES_DIR}/dns/README.rst"

@dhermes
Moving all dns files into subdirectory.
5589e21 
Done via:

$ mkdir -p dns/google/cloud
$ cp google/__init__.py dns/google/__init__.py
$ git add dns/google/__init__.py
$ cp google/cloud/__init__.py dns/google/cloud/__init__.py
$ git add dns/google/cloud/__init__.py
$ git mv google/cloud/dns dns/google/cloud/dns
$ git mv unit_tests/dns dns/unit_tests
@dhermes
Making dns subpackage into a proper package.
d7ccea6 
- Adding README, setup.py, MANIFEST.in, .coveragerc and tox.ini
- Adding google-cloud-dns as a dependency to the umbrella
  package
- Adding the dns subdirectory into the list of packages
  for verifying the docs
- Incorporating the dns subdirectory into the umbrella
  coverage report
- Adding the dns only tox tests to the Travis config
- Adding {toxinidir}/../core as a dependency for the dns
  tox config
@dhermes dhermes added api: dns Issues related to the Cloud DNS API. packaging labels Sep 26, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2016
@dhermes dhermes mentioned this pull request Sep 26, 2016
Closed
32 tasks
@dhermes dhermes changed the title Move storage code into a subpackage Move dns code into a subpackage Sep 26, 2016
theacodes
theacodes approved these changes Sep 26, 2016
View reviewed changes
Copy link
Contributor

@theacodes theacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small teensy nit

dns/README.rst
Quick Start
-----------

::

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes dhermes merged commit 796f745 into googleapis:master Sep 26, 2016
@dhermes dhermes deleted the make-dns-subpackage branch September 26, 2016 21:19
@dhermes dhermes mentioned this pull request Sep 26, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes approved these changes

Assignees

@tseaver tseaver

@theacodes theacodes

Labels
api: dns Issues related to the Cloud DNS API. cla: yes This human has signed the Contributor License Agreement. packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dhermes @theacodes @tseaver @googlebot