Move language code into a subpackage #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
32 tasks
theacodes
reviewed
Sep 26, 2016
|
|
||
| $ pip install --upgrade google-cloud-language | ||
| $ # OR | ||
| $ pip install --upgrade google-cloud-natural-language |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
theacodes
approved these changes
Sep 26, 2016
Done via: $ mkdir -p language/google/cloud $ cp google/__init__.py language/google/__init__.py $ git add language/google/__init__.py $ cp google/cloud/__init__.py language/google/cloud/__init__.py $ git add language/google/cloud/__init__.py $ git mv google/cloud/language language/google/cloud/language $ git mv unit_tests/language language/unit_tests
- Adding README, setup.py, MANIFEST.in, .coveragerc and tox.ini
- Adding google-cloud-language as a dependency to the umbrella
package
- Adding the language subdirectory into the list of packages
for verifying the docs
- Incorporating the language subdirectory into the umbrella
coverage report
- Adding the language only tox tests to the Travis config
- Adding {toxinidir}/../core as a dependency for the language
tox config
dhermes
force-pushed
the
make-language-subpackage
branch
from
93a47b0
to
3af2d13
Compare
|
For some reason this didn't kick off a new Travis build when I rebased on top of #2428. Maybe the "approval" stops it? |
|
Here is the orignal (green) PR build: https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/162895936 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created via: https://gist.github.com/dhermes/e239691aa584bd56a5352e34aad27cf3