Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nox unittest updates #4646

Merged
merged 1 commit into from Jan 3, 2018
Merged

nox unittest updates #4646

merged 1 commit into from Jan 3, 2018

Conversation

chemelnucfin
Copy link
Contributor

Manually changed. Where do I change the generator?
@dhermes @lukesneeringer

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 20, 2017
@@ -19,8 +19,36 @@


@nox.session
@nox.parametrize('python_version', ['2.7', '3.4', '3.5', '3.6'])
def unit_tests(session, python_version):
def default(session):

This comment was marked as spam.

This comment was marked as spam.

This is intended to be run **without** an interpreter set, so
that the current ``python`` (on the ``PATH``) or the version of
Python corresponding to the ``nox`` binary the ``PATH`` can
run the tests.

This comment was marked as spam.



@nox.session
def cover(session):

This comment was marked as spam.

This comment was marked as spam.

import os

import nox


LOCAL_DEPS = (
os.path.join('..', 'api_core'),
os.path.join('..', 'core'),

This comment was marked as spam.

container/nox.py Outdated
import os

import nox


LOCAL_DEPS = (
os.path.join('..', 'api_core'),
os.path.join('..', 'core'),

This comment was marked as spam.

dataproc/nox.py Outdated
import os

import nox


LOCAL_DEPS = (
os.path.join('..', 'api_core'),
os.path.join('..', 'core'),

This comment was marked as spam.

session.install('coverage', 'pytest-cov')
session.run('coverage', 'report', '--show-missing', '--fail-under=70')
# uncomment when coverage is met
# session.run('coverage', 'report', '--show-missing', '--fail-under=100')

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

container/nox.py Outdated

This is intended to be run **without** an interpreter set, so
that the current ``python`` (on the ``PATH``) or the version of
Python corresponding to the ``nox`` binary the ``PATH`` can

This comment was marked as spam.

@chemelnucfin chemelnucfin merged commit e58fecd into googleapis:master Jan 3, 2018
@chemelnucfin chemelnucfin deleted the nox branch January 3, 2018 06:04
parthea pushed a commit that referenced this pull request Sep 22, 2023
parthea pushed a commit that referenced this pull request Sep 22, 2023
parthea pushed a commit that referenced this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants