Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging: s/print/logging.info/ #5569

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Conversation

helen-fornazier
Copy link
Contributor

@helen-fornazier helen-fornazier commented Jul 4, 2018

The function print sends the output to stdout disturbing the output of
the application.
Use logging instead which sends the logs to stderr by default or to the
destination configured by the application.

Closes #5565

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 4, 2018
@theacodes
Copy link
Contributor

@helen-fornazier how would you feel about using sys.stderr instead of logging?

@tseaver
Copy link
Contributor

tseaver commented Jul 9, 2018

FWIW, I'd much rather use sys.stderr, given the circularity of having our log handlers calling back into the stdlib logging stuff.

The function print sends the output to stdout disturbing the output of
the application.
Redirect its output to stderr instead with sys.stderr
@helen-fornazier
Copy link
Contributor Author

I just updated the PR to use sys.stderr, could you please take another look?

Thanks

@theacodes theacodes merged commit e1e714c into googleapis:master Jul 10, 2018
@theacodes
Copy link
Contributor

Thank you, @helen-fornazier!

@helen-fornazier helen-fornazier deleted the logging branch July 11, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants