Bigtable:Adding eq and ne methods for row set #6025

sumit-ql · 2018-09-19T16:23:54Z

eq and ne methods for RowSet and RowRange.
Unit tests.

bigtable/google/cloud/bigtable/row_set.py

+            return False
+
+        if not sorted(other.row_keys) == sorted(self.row_keys):
+            return False


bigtable/google/cloud/bigtable/row_set.py

+            try:
+                row_ranges.remove(each)
+            except ValueError:
+                return False


bigtable/google/cloud/bigtable/row_set.py

+            self.start_inclusive,
+            self.end_key,
+            self.end_inclusive,
+        )


sumit-ql added 2 commits September 17, 2018 10:22

Adding __eq__ and __ne__ methods

3ac9d11

Code coverage

ddd3edf

sumit-ql requested a review from theacodes as a code owner September 19, 2018 16:23

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 19, 2018

tseaver suggested changes Sep 19, 2018

View reviewed changes

Review comments implementations.

d330b11

tseaver reviewed Sep 20, 2018

View reviewed changes

bigtable/google/cloud/bigtable/row_set.py

self.start_inclusive,

self.end_key,

self.end_inclusive,

)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

using _key() in __eq__ method of RowRange

72b7c49

tseaver approved these changes Sep 20, 2018

View reviewed changes

tseaver merged commit 16a358e into googleapis:master Sep 20, 2018

sumit-ql deleted the implement-__eq__-for-row_set branch September 21, 2018 15:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bigtable:Adding eq and ne methods for row set #6025

Bigtable:Adding eq and ne methods for row set #6025

sumit-ql commented Sep 19, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Bigtable:Adding __eq__ and __ne__ methods for row set #6025

Bigtable:Adding __eq__ and __ne__ methods for row set #6025

Conversation

sumit-ql commented Sep 19, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Bigtable:Adding eq and ne methods for row set #6025

Bigtable:Adding eq and ne methods for row set #6025