Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bigtable: Add retry parameter to 'Table.read_rows()'. #6281

Merged
merged 5 commits into from
Oct 30, 2018
Merged

Bigtable: Add retry parameter to 'Table.read_rows()'. #6281

merged 5 commits into from
Oct 30, 2018

Conversation

sumit-ql
Copy link
Contributor

@sumit-ql sumit-ql commented Oct 20, 2018 •
edited by tseaver
Loading

Closes #6186

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 20, 2018
@sduskis
Copy link
Contributor

sduskis commented Oct 21, 2018

@sumit-ql, there's an error in CircleCI:

/var/code/gcp/bigtable/google/cloud/bigtable/row_data.py:docstring of google.cloud.bigtable.row_data.DEFAULT_RETRY_READ_ROWS:3:Inline interpreted text or phrase reference start-string without end-string.

@tseaver tseaver changed the title Adding retry parameter in Table.read_rows() method. Bigtable: Add retry parameter to 'Table.read_rows()'. Oct 22, 2018
@tseaver tseaver added the api: bigtable Issues related to the Bigtable API. label Oct 22, 2018
tseaver
tseaver suggested changes Oct 23, 2018
View reviewed changes
bigtable/google/cloud/bigtable/row_data.py
@@ -333,7 +355,8 @@ class PartialRowsData(object):
STATE_ROW_IN_PROGRESS: ROW_IN_PROGRESS,
STATE_CELL_IN_PROGRESS: CELL_IN_PROGRESS}

def __init__(self, read_method, request):
def __init__(self, read_method, request,
retry=DEFAULT_RETRY_READ_ROWS):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

bigtable/google/cloud/bigtable/row_data.py
predicate=_retry_read_rows_exception,
deadline=60)
return retry_(self._read_next, on_error=self._on_error)()
return self.retry(self._read_next, on_error=self._on_error)()

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

bigtable/google/cloud/bigtable/table.py
@@ -340,7 +350,7 @@ def read_rows(self, start_key=None, end_key=None, limit=None,
data_client = self._instance._client.table_data_client
return PartialRowsData(
data_client.transport.read_rows,
request_pb)
request_pb, retry)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver
tseaver suggested changes Oct 29, 2018
View reviewed changes
bigtable/tests/unit/test_row_data.py Outdated Show resolved Hide resolved
bigtable/tests/unit/test_table.py Outdated Show resolved Hide resolved
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 29, 2018
@kokoro-team kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 29, 2018
@sumit-ql
Copy link
Contributor Author

@tseaver Done the changes suggested by you. Please review.

@tseaver tseaver merged commit 9d6e68f into googleapis:master Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduskis sduskis sduskis approved these changes

@tseaver tseaver tseaver approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sumit-ql @sduskis @tseaver @googlebot @kokoro-team