Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pub/Sub: surface publish future in documentation #8229

Merged
merged 2 commits into from
Jun 6, 2019
Merged

Pub/Sub: surface publish future in documentation #8229

merged 2 commits into from
Jun 6, 2019

Conversation

anguillanneuf
Copy link
Contributor

@anguillanneuf anguillanneuf commented Jun 5, 2019

This makes sure that the Publish Future documentation shows up here, and users can navigate to its own page.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 5, 2019
@anguillanneuf anguillanneuf added api: pubsub Issues related to the Pub/Sub API. type: docs Improvement to the documentation for an API. labels Jun 5, 2019
@anguillanneuf anguillanneuf requested a review from plamut June 5, 2019 21:51
@busunkim96 busunkim96 removed their request for review June 5, 2019 23:47
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built the docs locally and the publisher Future link is now indeed present under the "Publishing Messages" bullet point of the API Documentation section.

The docs for the publisher and subscriber futures also seem in order, approving. 👍

@plamut plamut merged commit cd57e65 into master Jun 6, 2019
@anguillanneuf anguillanneuf deleted the futures branch June 6, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants