Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

talent: Add missing batch samples #7431

Closed
xtineskim opened this issue Nov 16, 2022 · 5 comments
Closed

talent: Add missing batch samples #7431

xtineskim opened this issue Nov 16, 2022 · 5 comments
Assignees
Labels
samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.

Comments

@xtineskim
Copy link

xtineskim commented Nov 16, 2022

In which file did you encounter the issue?

There are missing samples in the talent directory, related to cl/488696692. Noticed it when completing the python talent migration (pr here)

Did you change the file? If so, how?

n/a

Describe the issue

Specifically, it is the job_search_batch_update_jobs and job_search_batch_create_jobs tags missing. Recommended steps going forward was to create new samples.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 16, 2022
@meredithslota
Copy link
Contributor

These region tags are present in these files, respectively:

https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/talent/job_search_batch_update_jobs.py#L15
https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/talent/job_search_batch_create_jobs.py#L15

We do still need to resolve the conflicting files, as the snippet tracking site is reporting duplicates, e.g. https://devrel.corp.google.com/snippets/job_search_batch_update_jobs?t=python

If you are getting an error in staging files, it could be due to the time it takes to index new samples in to the GitHub mirror that DevSite uses (it should take less than 2h though). I think this is ok to close.

@meredithslota
Copy link
Contributor

Just kidding, I was multi-tasking and missed that you were referring to Java samples, not Python. Apologies.

@meredithslota
Copy link
Contributor

Ok, it looks like those were "legacy generated samples" that were removed in googleapis/java-talent#783 without being removed from the documentation.

@kweinmeister kweinmeister added the type: cleanup An internal cleanup or hygiene concern. label Dec 5, 2022
@averikitsch averikitsch assigned xtineskim and unassigned averikitsch Dec 5, 2022
@xtineskim xtineskim removed their assignment Dec 13, 2022
@xtineskim
Copy link
Author

Not sure if i am the best person to tackle this issue, not sure what next action items would be?

@kweinmeister
Copy link
Contributor

Tracking this in an internal docs issue, closing it out here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

4 participants