Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test needed for speech/src/main/java/com/example/speech/InfiniteStreamRecognize.java #8261

Open
anguillanneuf opened this issue Jun 13, 2023 · 1 comment · May be fixed by #9336
Open

Test needed for speech/src/main/java/com/example/speech/InfiniteStreamRecognize.java #8261

anguillanneuf opened this issue Jun 13, 2023 · 1 comment · May be fixed by #9336
Assignees
@ssvir
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: process A process-related concern. May include testing, release, or the like.

Comments

@anguillanneuf
Copy link
Member

anguillanneuf commented Jun 13, 2023 •
edited

This sample is missing a test: speech/src/main/java/com/example/speech/InfiniteStreamRecognize.java

The initial PR from years ago had no such requirement, which is no longer the case now.
@anguillanneuf anguillanneuf added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. triage me I really want to be triaged. labels Jun 13, 2023
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 13, 2023
@anguillanneuf anguillanneuf mentioned this issue Jun 13, 2023
Closed
11 tasks
@anguillanneuf anguillanneuf removed their assignment Jun 14, 2023
@minherz
Copy link
Contributor

minherz commented Jan 17, 2024

Hello @gericdong, please assign someone to implement a test for this code sample.

@minherz minherz added type: process A process-related concern. May include testing, release, or the like. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. triage me I really want to be triaged. labels Jan 17, 2024
@ssvir ssvir linked a pull request May 20, 2024 that will close this issue
Open
11 tasks
@ssvir ssvir assigned ssvir and unassigned gericdong May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssvir ssvir

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create test for a speech sample (InfiniteStreamRecognize) GoogleCloudPlatform/java-docs-samples
6 participants
@minherz @anguillanneuf @ssvir @gericdong and others