Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add regional support to ComputeNetworkEndpointGroup #322

Closed
flunderpero opened this issue Nov 29, 2020 · 7 comments
Closed

add regional support to ComputeNetworkEndpointGroup #322

flunderpero opened this issue Nov 29, 2020 · 7 comments

Comments

@flunderpero
Copy link

Describe the bug
I am trying to setup a load balancer for our Cloud Run services, but I am unable to create a ComputeNetworkEndpointGroup of type SERVERLESS.

I am able to specify SERVERLESS as networkEndpointType but location is expected to be a zone and a SERVERLESS endpoint group requires a region.

The error message is either:

  Warning  UpdateFailed  2s (x12 over 14s)  computenetworkendpointgroup-controller  Update call failed: error fetching live state: error reading underlying resource: summary: Error when reading or editing ComputeNetworkEndpointGroup "projects/tkt-dev-pero/zones/europe-west1/networkEndpointGroups/testneg": googleapi: Error 400: Invalid value for field 'zone': 'europe-west1'. Unknown zone., invalid, detail:

... when I try to use a region as location, or:

 NetworkEndpointGroup: googleapi: Error 400: Invalid value for field 'resource.networkEndpointType': 'SERVERLESS'. Network endpoint of type SERVERLESS is only allowed in regional scope., invalid, detail:

Besides that, I don't think there is a way to specify things like cloud-run-url-mask, so my attempt to create a proper endpoint group would be futile anyway. :-)

ConfigConnector Version
1.29.0

To Reproduce
Steps to reproduce the behavior:

YAML snippets:

# This is just a reference to the pre-existing default network ...
apiVersion: compute.cnrm.cloud.google.com/v1beta1
kind: ComputeNetwork
metadata:
  name: default
---
apiVersion: compute.cnrm.cloud.google.com/v1beta1
kind: ComputeNetworkEndpointGroup
metadata:
  name: testneg
spec:
  location: europe-west1-c
  networkEndpointType: SERVERLESS
  networkRef:
    name: default
@flunderpero flunderpero added the bug Something isn't working label Nov 29, 2020
@xiaobaitusi
Copy link
Contributor

Hi @flunderpero, currently ConfigConnector only support zonal network endpoint group; I have added the request of regional network endpoint group into our backlog. We will plan and work on it and let you know when we have more information.

@xiaobaitusi xiaobaitusi added resource request and removed bug Something isn't working labels Nov 30, 2020
@xiaobaitusi xiaobaitusi changed the title Unable to create a SERVERLESS ComputeNetworkEndpointGroup add regional support to ComputeNetworkEndpointGroup Nov 30, 2020
@travisrandolph-bestbuy
Copy link

@xiaobaitusi We are also interested in this request. Has there been any update on adding regional support so we can support serverless NEG's through KCC?

@jcanseco
Copy link
Member

Hello @travisrandolph-bestbuy, no updates yet on this request, but we'll let you know once we have any updates to share.

In the meantime, could you elaborate on whether this issue is a blocker, friction point, or nice-to-have for you?

@jcanseco
Copy link
Member

Related: #502 (asks for both regional and global support for ComputeNetworkEndpointGroup)

@travisrandolph-bestbuy
Copy link

travisrandolph-bestbuy commented Nov 15, 2021

@jcanseco Sorry for not replying sooner. This is a friction point for us. Currently we have engineers who need to create the serverless NEG and attach it to our KCC created Load Balancer/URL Map.

@maqiuyujoyce
Copy link
Collaborator

Thanks for the response, @travisrandolph-bestbuy !

@jcanseco
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants