Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigTable GCPolicy Max Age Duration "d" (for days) is not working correctly #624

Closed
2 tasks done
joepeterson-bestbuy opened this issue Mar 7, 2022 · 3 comments
Closed
2 tasks done
Labels
bug Something isn't working

Comments

@joepeterson-bestbuy
Copy link

Checklist

Bug Description

When deploying a BigTable GCPolicy resource, and specifying a maxAge duration of "90d", the resource fails with the following error:
Warning UpdateFailed 11s (x5 over 5m47s) bigtablegcpolicy-controller Update call failed: error calculating diff: time: unknown unit "d" in duration "90d"

However, all other units including ms, s, m, h, appear to work just fine.

Additional Diagnostic Information

Kubernetes Cluster Version

Client Version: v1.19.4
Server Version: v1.20.10-gke.1600

Config Connector Version

1.70.0

Config Connector Mode

namespaced

@joepeterson-bestbuy joepeterson-bestbuy added the bug Something isn't working label Mar 7, 2022
@xiaobaitusi
Copy link
Contributor

Hi @joepeterson-bestbuy, I think that the root cause is that the underlying terraform resource uses the time.ParseDuration() which doesn't support d time unit.

I would suggest to use h instead to unblock yourself now. If you really like to support d, do you mind creating an issue in https://github.com/hashicorp/terraform-provider-google-beta to surface the feature request?

@kevinsi4508
Copy link

kevinsi4508 commented Oct 25, 2022

This should be resolved by using gc_rules. Currently we are waiting for KCC to update to the latest Google Terraform Provider version.

@mbzomowski
Copy link

spec.gcRules has been added to BigTableGCPolicy as of Config Connector v1.97.0. We don't recommend using maxAge, maxVersion or mode for defining a
BigTableGCPolicy as these fields have known drift detection issues. Instead, please use gcRules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants