Fix set blockOwnerDeletion failures for OwnerReferencesPermissionEnforcement enabled clusters #797
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
3 tasks
kaovilai
changed the title
|
Working on obtaining CLA with @eparis |
|
Looked for ways to test SA clusterrole.. seems like not easy with envtest. |
kaovilai
changed the title
kaovilai
changed the title
|
@diviner524 could you please review? |
diviner524
reviewed
Apr 7, 2023
If [OwnerReferencesPermissionEnforcement](https://kubernetes.io/docs/reference/access-authn-authz/admission-controllers/#ownerreferencespermissionenforcement) is turned on, such as on OpenShift, ConfigConnector operator would fail with error `forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on` Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Limit finalizers role to update verb Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #434
If OwnerReferencesPermissionEnforcement admission controller is enabled, such as on OpenShift, ConfigConnector operator would fail with error
forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers onThis PR ensures that operator's manager role has sufficient permission to update finalizer on a configconnector resource which will then allow us to set blockOwnerDeletion on resources created via Reconcile of a ConfigConnector.