Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAMPolicyMember.spec.member should be able to be a reference to an IAMServiceAccount #89

Closed
dmacthedestroyer opened this issue Feb 18, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@dmacthedestroyer
Copy link

Instead of the member field being a regex-enforced string, we should also be able to reference an IAMServiceAccount CRD, similar in fashion to the Specifying resource references documentation.

This would be especially helpful because it would remove the need to provide the Google Project ID whenever the service account is created within the same project as the cluster. For us, this would mean one less template parameter being passed around through configs in order to render the Helm template.

An example:
currently, from the repo's example:

spec:
  # replace ${PROJECT_ID?} with your project name
  member: serviceAccount:iampolicymember-dep-pubsub@${PROJECT_ID?}.iam.gserviceaccount.com

proposed:

spec:
  member: 
    iamServiceAccountRef: 
      name: iampolicymember-dep-pubsub
@maqiuyujoyce
Copy link
Collaborator

Hi @dmacthedestroyer, thank you for your feedback. We've also received the same request from another customer. We are currently looking into this feature. Will let you know when we have any updates.

@maqiuyujoyce maqiuyujoyce added the enhancement New feature or request label Feb 22, 2020
@morgante
Copy link

@maqiuyujoyce Any update here? This is currently cumbersome and painful.

@jcanseco
Copy link
Member

jcanseco commented Jul 17, 2020

Hi @morgante, our plan is to support it as part of our CRD version bumps sometime later this year.

@jcanseco
Copy link
Member

jcanseco commented Jan 6, 2021

Hi all, it is now possible in KCC v1.34.0 to reference an IAMServiceAccount as the member in an IAMPolicyMember using the spec.memberFrom.serviceAccountRef field. We will be updating the docs for IAMPolicyMember in a bit to include descriptions and sample usage of the new spec.memberFrom field.

Closing this issue now. Feel free to follow-up with comments if you have any further questions.

@jcanseco jcanseco closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants