Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-to-sd] Support custom paths #159

Closed
valyagolev opened this issue May 29, 2018 · 4 comments
Closed

[prometheus-to-sd] Support custom paths #159

valyagolev opened this issue May 29, 2018 · 4 comments

Comments

@valyagolev
Copy link

Right now the path to /metrics is hardcoded in the prometheus-to-sd's source (and it doesn't even seem documented...). Had to do some code-digging to find where I should serve my metrics.

However, I think there should be ways to configure this path. My use-case is that I want to expose two endpoints with different paths: one for pod-level metrics, another one for service-level metrics (the latter are harder to calculate and I want to do it only once per service per interval, not once per pod per interval).

@x13n
Copy link
Contributor

x13n commented May 29, 2018

We'd like to make prom-to-sd runnable as a DaemonSet, which means it would have to be more configurable than it is today. Your request appears to be a part of that configuration.
cc @loburm @cezarygerard

@loburm
Copy link
Member

loburm commented May 29, 2018

#124 fixes this issue. But we haven't released a new version of prometheus-to-sd that supports it, I'll try to do it next week.

@loburm loburm closed this as completed May 29, 2018
@valyagolev
Copy link
Author

@x13n that sounds very useful - is there any estimate of the work still needed to make it work as a DaemonSet?

@x13n
Copy link
Contributor

x13n commented Jun 11, 2018

Nope, I don't think so. Shouldn't be too hard though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants