Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/systemd: Add tmpfiles.d file #3602

Merged
merged 1 commit into from Mar 11, 2015

Conversation

cgwalters
Copy link
Contributor

Now that that the apiserver can auto-generate self-signed
certificates, and drop them in /var/run/kubernetes (which is really
/run/kubernetes), we need to ensure it's created on boot.

(I'm not sure why the default isnt' persistent self-signed
certificates, but that's a different patch)

Now that that the apiserver can auto-generate self-signed
certificates, and drop them in /var/run/kubernetes (which is really
/run/kubernetes), we need to ensure it's created on boot.

(I'm not sure why the default isnt' *persistent* self-signed
 certificates, but that's a different patch)
@cgwalters
Copy link
Contributor Author

/cc @eparis

@erictune
Copy link
Member

erictune commented Mar 4, 2015

@cgwalters @eparis what are your plans for this PR? May I close until you are ready to come back to it?

@eparis
Copy link
Contributor

eparis commented Mar 9, 2015

@cgwalters I know on RHEL/Fedora /run/ == /var/run/. But if kube is specifically looking in /var/run, shouldn't we be creating the dir in /var/run instead of in /run, just in case someone somehow has a setup where they are not the same?

@cgwalters
Copy link
Contributor Author

Any systemd-using system has /run -> /var/run. And systemd-tmpfiles only exists on systemd systems. Anyone packaging Kubernetes for an old system would need to use /var/run, but they'd do that in their packaging/init script.

@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@cgwalters
Copy link
Contributor Author

@googlebot I'm a Red Hat employee.

eparis added a commit that referenced this pull request Mar 11, 2015
@eparis eparis merged commit d12f989 into kubernetes:master Mar 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants