Updating the guestbook example to v1beta3 #7194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@briandorsey FYI |
|
Fixing tests |
nikhiljindal
force-pushed
the
example
branch
2 times, most recently
from
ee640e3
to
888e44a
Compare
|
Tests fixed! |
|
cc @piosz |
|
|
||
| Services find the containers to load balance based on pod labels. | ||
|
|
||
| The pod that you created in Step One has the label `name=redis-master`. The selector field of the service determines *which pods will receive the traffic* sent to the service, and the port and containerPort (targetPort in v1beta3 and higher APIs) information defines what port the service proxy will run at. | ||
| The pod that you created in Step One has the label `name=redis-master`. The selector field of the service determines *which pods will receive the traffic* sent to the service, and the port and containerPort (targetPort in v1beta3 and higher APIs) information defines what port the service proxy will run at. |
There was a problem hiding this comment.
Please make v1beta3 the primary text and older APIs in paretheses.
There was a problem hiding this comment.
Or remove mention of the old fields entirely, since we're removing the old example, anyway.
|
One minor comment. Otherwise LGTM. Thanks! |
|
LGTM |
bgrant0607
added
the
lgtm
bgrant0607
added a commit
that referenced
this pull request
Apr 23, 2015
Updating the guestbook example to v1beta3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #6584