Make nodes report their external IP rather than the master's. #7530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. FYI @bgrant0607 @davidopp this changes the semantics of external IP on GCE (to be correct for the nodes). |
|
e2e tests pass |
|
... and we are still waiting on shippable/travis. |
|
2+ hours for Travis and waiting? Sheesh... |
Merged
|
ping @roberthbailey: Travis is now OK |
|
I'm fine with this. Travis is green. |
bgrant0607
added a commit
that referenced
this pull request
Apr 30, 2015
Make nodes report their external IP rather than the master's.
roberthbailey
added a commit
to roberthbailey/kubernetes
that referenced
this pull request
May 27, 2015
server. This is in many ways a revert of kubernetes#7530 but after auditing the code I found that this function is now only used to determine an address of the node where it is currently running.
roberthbailey
added a commit
to roberthbailey/kubernetes
that referenced
this pull request
May 28, 2015
server. This is in many ways a revert of kubernetes#7530 but after auditing the code I found that this function is now only used to determine an address of the node where it is currently running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7412.
Please review, but don't merge quite yet (running e2es).