Add image-related methods to DockerManager #7578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yujuhong
force-pushed
the
docker_manager
branch
from
3a9d45d
to
76fd16c
Compare
|
Rebased. |
|
LGTM |
| for _, i := range actualImages { | ||
| actual.Insert(i.ID) | ||
| } | ||
| if !reflect.DeepEqual(expected.List(), actual.List()) { |
There was a problem hiding this comment.
Is this order deterministic? Since it's converting from a map I don't think it is.
There was a problem hiding this comment.
It is. util.StringSet sorts before returns.
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/util/set.go#L122
There was a problem hiding this comment.
I will add a comment for clarity.
There was a problem hiding this comment.
Ah, thanks for the pointer. Sounds good.
There was a problem hiding this comment.
It's alright, it's a failure to read the specification on my part.
|
LGTM, minor nits. |
This change is part of the efforts to make DockerManager implement the Runtime interface. The change also modifies the interface slightly to work with existing code, and aggregates the type converting functions to convert.go.
yujuhong
force-pushed
the
docker_manager
branch
from
76fd16c
to
83c599e
Compare
|
Addressed the comments in the new patch. Thanks! |
|
LGTM, thanks @yujuhong! |
|
Shippable is green, merging. |
vmarmol
added a commit
that referenced
this pull request
Apr 30, 2015
Add image-related methods to DockerManager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is part of the efforts to make DockerManager implement the Runtime
interface.
The change also modifies the interface slightly to work with existing
code, and aggregates the type converting functions to convert.go.