Support recovery from in the middle of a rename.

[brendandburns]

Code written @ 12:30am on a plane. Treat with skepticisim...

(and don't merge yet, I want to add tests)

[brendandburns]

Ok, I added tests to validate this. Please review.

thanks!
--brendan

[j3ffml]

lgtm.

[j3ffml]

Wait, why would oldRc ever be nil here? If we didn't find it, wouldn't we would have returned already inside the block starting at 137?

[j3ffml]

Might be time to break this function up. Too hard to follow the logic if you have to scroll thru multiple screen lengths.

[brendandburns]

Addressed comments, and merged in retries changes. Please take another look.

Thanks!
--brendan

[j3ffml]

We should only be doing rename if --image was set. Rolling updates to an rc from filename should use the name from the schema file.

[brendandburns]

well, if len(args) == 1 and --image isn't set, it will error out earlier in validateArgs, but I'm happy to add an explicit check here if you prefer.

[j3ffml]

I don't see that check in validateArguments. Also, len(args) == 1 is expected for the --filename case, so that check wouldn't quite work. Just moving this assignment under the if len(image) != 0 block should suffice.

[j3ffml]

Some function references need fixing. From travis:

# github.com/GoogleCloudPlatform/kubernetes/pkg/kubectl/cmd
_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/pkg/kubectl/cmd/rollingupdate_test.go:174: undefined: addDeploymentKeyToReplicationController
_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/pkg/kubectl/cmd/rollingupdate_test.go:264: undefined: updateWithRetries
FAIL    github.com/GoogleCloudPlatform/kubernetes/pkg/kubectl/cmd [build failed]

[brendandburns]

Ok, I think I forgot to push some pieces. Re-pushed, please take another look.

[j3ffml]

lgtm. will merge on green.