Cobra update and bash completions fix #7776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jlowdermilk unsure whether you have context on conbra and bash completions—feel free to reassign elsewhere if not |
|
lgtm. Test failure looks like flake. I kicked travis. |
|
Hmmm, still broken: https://travis-ci.org/GoogleCloudPlatform/kubernetes/jobs/61327954 Unit test failing in pkg/client for v1beta1. Can you take a look? If you don't think this should affect it, rebasing may resolve. |
Picks up some bash completions fixes and implements deprecated cobra commands
Because we updated cobra, we get a better set of bash completions
|
Shippable green, merging. |
j3ffml
added a commit
that referenced
this pull request
May 6, 2015
Cobra update and bash completions fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filename extensions weren't working. kubectl create -f [tab][tab] wasn't showing .json/yaml files. Only directories.