-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore latency metrics for events #7857
Conversation
See #7561 |
metrics, err := ReadLatencyMetrics(c) | ||
if err != nil { | ||
return 0, err | ||
} | ||
ignored := make(map[string]bool) | ||
for _, resource := range ignoredResources { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest declaring this as a util.StringSet and checking the set with Has, instead of a list that becomes a dict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
LGTM with one nit |
88b934e
to
a1a61d9
Compare
LGTM - will merge on green. |
Ignore latency metrics for events
This should fix some of the jenkins failure.
@wojtek-t @bprashanth @quinton-hoole