Serializing the test cases for connection resource

[balanaguharsha]

Serializing the test cases for connection resource

Fixed hashicorp/terraform-provider-google#16720

Release Note Template for Downstream PRs (will be copied)

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 981 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 981 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 10
Passed tests: 9
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• integrationconnectors

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIntegrationConnectorsConnection

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccIntegrationConnectorsConnection[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 981 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 981 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• integrationconnectors

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 981 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 981 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 10
Passed tests: 9
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• integrationconnectors

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIntegrationConnectorsConnection

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccIntegrationConnectorsConnection[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[melinath]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 981 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 981 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 10
Passed tests: 9
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• integrationconnectors

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIntegrationConnectorsConnection

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccIntegrationConnectorsConnection[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[melinath]

Suggested change

	proxy_destination_config {
	key = "proxy_destination_config"
	destination {
	host = "https://proxy.zendesk.com"
	port = 80
	}
	}

This is causing the error: Blocks of type "proxy_destination_config" are not expected here. I don't see this field documented for this resource: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/integration_connectors_connection

[melinath]

Suggested change

	dead_letter_config{
	topic = "test-topic"
	project_id = "test-project-id"
	}

This is causing the error: Blocks of type "dead_letter_config" are not expected here. I don't see this field documented for this resource: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/integration_connectors_connection

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 981 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 981 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 10
Passed tests: 9
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• integrationconnectors

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIntegrationConnectorsConnection

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccIntegrationConnectorsConnection[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 974 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 974 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 10
Passed tests: 9
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• integrationconnectors

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIntegrationConnectorsConnection

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccIntegrationConnectorsConnection[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1007 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 1007 insertions(+), 2 deletions(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1007 insertions(+), 1026 deletions(-))
google-beta provider: Diff ( 3 files changed, 1007 insertions(+), 1026 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1008 insertions(+), 1026 deletions(-))
google-beta provider: Diff ( 3 files changed, 1008 insertions(+), 1026 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3
Passed tests: 2
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• integrationconnectors

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIntegrationConnectorsConnection

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 3
Passed tests: 2
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• integrationconnectors

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIntegrationConnectorsConnection

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccIntegrationConnectorsConnection[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccIntegrationConnectorsConnection[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1009 insertions(+), 1026 deletions(-))
google-beta provider: Diff ( 3 files changed, 1009 insertions(+), 1026 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3
Passed tests: 2
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• integrationconnectors

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIntegrationConnectorsConnection

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccIntegrationConnectorsConnection[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1010 insertions(+), 1026 deletions(-))
google-beta provider: Diff ( 3 files changed, 1010 insertions(+), 1026 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3
Passed tests: 2
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• integrationconnectors

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIntegrationConnectorsConnection

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccIntegrationConnectorsConnection[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[melinath]

Marking as changes requested to track the t.Parallel() change.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1009 insertions(+), 1025 deletions(-))
google-beta provider: Diff ( 3 files changed, 1009 insertions(+), 1025 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3
Passed tests: 3
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• integrationconnectors

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

[balanaguharsha]

PTAL at convenience

[melinath]

LGTM - the serialized tests are copies of the example tests plus a few small corrections to get them passing.

Would it make sense to backport the fixes to the examples we show in docs? (In a separate PR - this one is good to go!)

[balanaguharsha]

So the fixes are rather on our API layer than here, so there is actually nothing to backfill and its already inline

[melinath]

There were a few changes you ended up making to the tests after serializing them, like adding explicit service accounts - I'm wondering if you might want to add those changes to the documented usage of the resource?