Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-merge Renovate pull-requests for patch/minor/digest #1428

Closed
NimJay opened this issue Dec 22, 2022 · 4 comments
Closed

Auto-merge Renovate pull-requests for patch/minor/digest #1428

NimJay opened this issue Dec 22, 2022 · 4 comments
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@NimJay
Copy link
Collaborator

NimJay commented Dec 22, 2022

Terminology

  • From semver.org (major.minor.patch):
    • major = incompatible API changes
    • minor = new functionality & backwards compatible
    • patch = bug fixes & backwards compatible
  • digest = similar to pull-request #1426

Background

  • Most of the pull-requests merged into main come from Renovate Bot (dependency updates).
  • Most of these updates are not major updates.
  • The review process for a non-major updates is: if the CI checks are passing, merge the pull-request.

Feature Request

  • Renovate Bot updates should be auto-merged if the following conditions are met:
    1. the update is one of: patch; minor; digest
    2. the relevant CI tests are passing
  • For now, major updates should go through a manual review.
    • We have experienced breakages of Online Boutique functionality because of major Renovate Bot updates (e.g., when pino was updated).
    • We could auto-merge major updates too once we have thorough end-to-end tests of most of Online Boutique (e.g., U.I. tests).

Additional Notes

  • This will free up a lot of the time that our team spends on reviewing Online Boutique pull-requests.
@NimJay NimJay changed the title Auto-merge Renovate pull-requests for patch/minor/digest updates Auto-merge Renovate pull-requests for patch/minor/digest Dec 22, 2022
@NimJay NimJay added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Dec 22, 2022
@gitsan13
Copy link

Hi @NimJay
I would like to give this issue a try. Can you please assign me to it?

@NimJay
Copy link
Collaborator Author

NimJay commented Jan 23, 2023

Hi @gitsan13,

First, thank you for your interest in contributing.
This issue (about auto-merging Renovate pull-requests) is more appropriate for someone with admin access to this GitHub repository.

If you'd like to work on something, I recommend: #693
But #693 is a big task because it involves multiple microservices.
So you could try #693 for a specific microservice (e.g., for the frontend — is alpine:3.17.0 the smallest base image we can use, or it there something smaller)?

@minherz
Copy link
Contributor

minherz commented Apr 19, 2023

@bourgeoisor for your tracking

@minherz minherz added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Apr 19, 2023
@bourgeoisor
Copy link
Member

Done here: #1835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants