Adservice error when building on windows

[geoff-maddock]

This looks related to #128, but I'm running code with the changes mentioned, I'm still seeing an error.

I'm following the instructions to build as per Option 1: Running locally with “Docker for Desktop”

skaffold run

Gets to the step building the Adservice and errors out with:

Building [adservice]...
Sending build context to Docker daemon  106.5kB
Step 1/16 : FROM openjdk:8-slim as builder
 ---> ca76a0748b8a
Step 2/16 : WORKDIR /app
 ---> Using cache
 ---> 864059e8cd26
Step 3/16 : COPY ["build.gradle", "gradlew", "./"]
 ---> Using cache
 ---> 48f29d815557
Step 4/16 : COPY gradlew gradlew
 ---> 55cc63a88dc3
Step 5/16 : RUN chmod +x gradlew
 ---> Running in 7e26c9e7ad17
 ---> 8133454b3890
Step 6/16 : RUN ./gradlew downloadRepos
 ---> Running in a190a32b5a88
/usr/bin/env: ‘sh\r’: No such file or directory
FATA[0018] build failed: building [adservice]: build artifact: The command '/bin/sh -c ./gradlew downloadRepos' returned a non-zero code: 127

[ahmetb]

Did you edit the Dockerfile by any chance? Looks like the file has a CRLF ending.

[geoff-maddock]

I cloned it to my windows machine and ran the skaffold build, so i didn't touch it before I got the error.

[geoff-maddock]

Got this to work by using this autocrlf parameter when cloning.

git clone https://github.com/GoogleCloudPlatform/microservices-demo.git --config core.autocrlf=input

[ahmetb]

I honestly don't know how would this happen.

It sounds like probably ALL cloned dockerfiles would be broken on your machine if that was the case. There are 10 dockerfiles in this repo alone. At any rate, glad to hear you figured out.

[geoff-maddock]

It doesn't really make sense to me either why it happened with JUST that dockerfile, but i'm not yet super familiar with this project. In any case, this is documented here now in case any other windows 10 pro users run into a similar issue.