Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger trace shows blank tags under Processes node #385

Closed
sundar-cs opened this issue Aug 25, 2020 · 5 comments
Closed

Jaeger trace shows blank tags under Processes node #385

sundar-cs opened this issue Aug 25, 2020 · 5 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.
Milestone

Comments

@sundar-cs
Copy link

sundar-cs commented Aug 25, 2020

Original issue title: Jaeger trace shows blank tags under Processes node

This is just a query about using this sample app on an existing k8s cluster (on AWS for instance)
(1)
Save the YAML from this link into a local file.
https://github.com/GoogleCloudPlatform/microservices-demo/blob/master/release/kubernetes-manifests.yaml
(2) Uncomment the JAEGER_SERVICE_ADDR name and value in all the services
(3) Create/Apply this YAML along with Jaeger (jaeger-all-in-one-template.yaml) onto the k8s cluster

The Jaeger UI (json view) shows the serviceName under Processes but the tags are always blank.
Whereas another sample app such as HotRod (released as part of Jaeger) shows non-empty list of tags (such as ip, hostname etc).

Is this difference attributed to OpenCensus talking to Jaeger Collector directly whereas HotRod talks to Jaeger Agent (via OpenTracing libraries) which in turn relays it to the Jaeger Collector ?
(with these tags getting inserted by the Agent or by the instrumentation code or library)

If so, what's the right way to generate the tags: would it be to route it via OpenCensus Agent ?
Or is there a version of this microservices-app that works with OpenTracing ? (or OpenTelemetry)

Sample outputs are attached (trimmed versions).
Thank you.

sample.hotrod.trimmed.json.txt
sample.googleapp.json.trimmed.txt

@askmeegs askmeegs added this to the 🚲 Q2 2021 milestone Mar 23, 2021
@askmeegs askmeegs added priority: p2 Moderately-important priority. Fix may not be included in next release. type: question Request for information or clarification. Not an issue. and removed area/monitoring priority/P2 what/question labels Apr 8, 2021
@sagarpatil23192
Copy link

+1

@bourgeoisor
Copy link
Member

To clarify, the normal trace tags are there but not the process tags correct?

If so, I've been able to reproduce this issue on GKE as well:

  • Create a GKE cluster;
  • Install the Jaeger operator with WATCH_NAMESPACE: "" (https://github.com/jaegertracing/jaeger-operator#getting-started);
  • Deploy Online Boutique with JAEGER_SERVICE_ADDR: "<name_of_jaeger_resource>-collector: 14268" (kubectl apply -f release/kubernetes-manifests.yaml);
  • Create a Jaeger resource in the default namespace (https://github.com/jaegertracing/jaeger-operator#getting-started)
  • Navigate to the newly created Jaeger Ingress' external IP and generate traces for any of the Online Boutique components;
  • Notice the "process" tags being grey'd out / empty:
    image

I spent some time troubleshooting this issue but can't seem to quite put my finger on why exactly the process tags aren't generated by the OpenCensus / Jaeger exporters. There is a way to append to the process tags manually (using JAEGER_TAGS: "key=value" but I don't think that is relevant to this issue, since we're looking for the pre-populated process tags (host, IP, version, etc.)

One thing to note is that the OpenCensus Jaeger exporters we are using hasn't been officially updated upstream since 2019 (e.g. https://github.com/census-ecosystem/opencensus-go-exporter-jaeger/releases). It is quite possible that an update may be needed to fix this process tags issue.

We are planning on eventually moving to OpenTelemetry, as OpenCensus is deprecating sometime in 2021. (#422)

@askmeegs askmeegs added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 21, 2021
@askmeegs
Copy link
Contributor

Hello! Just a heads up that we're still aware of this issue, but fixing it is not high priority this quarter due to Jaeger being open-source and not a Google product. We will update when we are able to tackle this. Thanks!

@bourgeoisor
Copy link
Member

Commenting to reset OSLO-- I'm wondering if this might be fixed alongside #422

@mathieu-benoit
Copy link
Contributor

Closing this one as Jaeger has been removed from the project: #1088, coming in 0.3.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

6 participants