Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pino instead of console.log #674

Closed
NimJay opened this issue Dec 29, 2021 · 11 comments · Fixed by #2263
Closed

Use pino instead of console.log #674

NimJay opened this issue Dec 29, 2021 · 11 comments · Fixed by #2263
Assignees
Labels
good first issue This issue is a good place to started contributing to this repository. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@NimJay
Copy link
Collaborator

NimJay commented Dec 29, 2021

Describe request or inquiry

What purpose/environment will this feature serve?

@NimJay NimJay added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Dec 29, 2021
@NimJay NimJay added type: cleanup An internal cleanup or hygiene concern. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 18, 2022
@NimJay
Copy link
Collaborator Author

NimJay commented Jul 14, 2022

Update (2022 July)

Just adding an update to cool this issue down (i.e., remove it from our team's out-of-SLO list).
No progress updates and this issue is still very low priority.
I wonder if this ticket will be addressed (indirectly) by #422 (i.e., will switching to OpenTelemetry render this issue irrelevant?).

@NimJay NimJay added the good first issue This issue is a good place to started contributing to this repository. label Sep 12, 2022
@aarushisoni
Copy link

Hi I want to contribute to this issue please assign me this issue

@NimJay
Copy link
Collaborator Author

NimJay commented Dec 7, 2022

Hi @aarushisoni,
Thanks again for your interest.
This is definitely a good first issue to work on. :)
I've assigned it to you.

@TonyBhargav
Copy link

Hi @NimJay since no progress in this issue can I get assigned to this issue. I'll be happy to work on this.
@aarushisoni are you still working on this?

@NimJay NimJay assigned TonyBhargav and unassigned aarushisoni Jan 23, 2023
@andresmc98
Copy link

Hi @NimJay
is someone working on this issue? i would like give it a shot c:

@NimJay NimJay assigned andresmc98 and unassigned TonyBhargav Apr 26, 2023
@NimJay
Copy link
Collaborator Author

NimJay commented Apr 26, 2023

Hi @andresmc98, :)

I don't think anyone was working on this. Correct my if I'm wrong, @TonyBhargav. :)
I just assigned it to you (@andresmc98).

Just a heads-up: please see before starting any work:

Thank you all, for your interest in contributing.

@andresmc98
Copy link

Thank you,
so i'll checks the docs first

@DracFiendMG
Copy link
Contributor

DracFiendMG commented Nov 12, 2023

Hi @NimJay, can you assign this one to me? I've already made relevant changes to both index.js and server.js files on my local. I want to confirm the changes with you.

@DracFiendMG
Copy link
Contributor

DracFiendMG commented Nov 12, 2023

@NimJay, I just noticed that /src/currencyservice/server.js already has pino implemented, can you confirm?

@DracFiendMG
Copy link
Contributor

DracFiendMG commented Nov 13, 2023

@NimJay, I've raised a PR: #2262
Can you look into it and let me know if I'm missing something?

@DracFiendMG
Copy link
Contributor

@NimJay, I've already committed my changes can you look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This issue is a good place to started contributing to this repository. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants