Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update skaffold in cloudbuild.yaml #761

Closed
3 tasks
NimJay opened this issue Mar 1, 2022 · 1 comment
Closed
3 tasks

Update skaffold in cloudbuild.yaml #761

NimJay opened this issue Mar 1, 2022 · 1 comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@NimJay
Copy link
Collaborator

NimJay commented Mar 1, 2022

Describe the bug

To Reproduce

  • We would have to create a Google Cloud Build Trigger pointing to the cloudbuild.yaml file in main.

Logs

  • I have not tested this breakage manually, but I assume we should see a message similar to this in the Google Cloud Build Trigger's logs:
WARN[0000] Your Skaffold version might be too old. Download the latest version (1.28.1) from:
  https://github.com/GoogleContainerTools/skaffold/releases/tag/v1.28.1
parsing skaffold config: error parsing skaffold configuration file: unknown skaffold config API version "skaffold/v2beta18". Set the config 'apiVersion' to a known value. Check https://skaffold.dev/docs/references/yaml/ for the list of valid API versions. Otherwise, check that your skaffold version is up-to-date.

Screenshots

N/A

Environment

  • Google Cloud Build

Additional context

N/A

Exposure

  • This has been broken for a while now (skaffold modules was added in Oct 2021).
  • We don't have data on how many people are relying on our cloudbuild.yaml file (i.e., for learning/demo purposes) — I assume it's minimal.
@NimJay NimJay added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Mar 1, 2022
@mathieu-benoit
Copy link
Contributor

Fixed by #885 with explanation there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants