Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Microservices Demo on Cloud Run #831

Closed
cc4i opened this issue May 15, 2022 · 7 comments
Closed

Run Microservices Demo on Cloud Run #831

cc4i opened this issue May 15, 2022 · 7 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@cc4i
Copy link
Contributor

cc4i commented May 15, 2022

Describe request or inquiry

The Microservices Demo should able to run on top of Cloud Run with somewhat changes. Redis would be based on Memory Store.

What purpose/environment will this feature serve?

Leverage Microservices Demo to demonstrates the power of Serverless.

@cc4i
Copy link
Contributor Author

cc4i commented May 15, 2022

Already done some jobs around that, I'd like to contribute with a proper PR if accept the request.

@NimJay
Copy link
Collaborator

NimJay commented May 18, 2022

This is related to #652.

@NimJay
Copy link
Collaborator

NimJay commented May 18, 2022

@grayside do you think https://github.com/GoogleCloudPlatform/cloud-run-samples is a better place for Cloud Run samples using microservices-demo (Online Boutique)?

The reason I ask: this (microservices-demo) repo is owned by the Anthos/GKE DPE team — and I worry about the Cloud-Run-related maintenance cost that the Anthos/GKE DPE team would have to deal with.

@cc4i, a few questions for you: :)

  1. Have you considered using a separate repository?
  2. Would you prefer to have the Cloud Run samples live in this repo? Is so, why?
  3. Have you talked to a Cloud Run tech writer (about turning your samples into a cloud.google.com tutorial)? If not, I think it'd be a cool idea (after you've merged the samples into some public repo of course).

@NimJay NimJay added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels May 18, 2022
@cc4i
Copy link
Contributor Author

cc4i commented Jul 26, 2022

@NimJay Thanks for pointing out. Idea was came from a PoC, maybe Cloud Run is good place to go if the repo is specific for Anthos/GKE.

@mathieu-benoit
Copy link
Contributor

Hi @NimJay, what do we want to do with this one? Closing and maybe documenting on the main README.md where end users can find the branches/repos with the support of Cloud Run?

@NimJay
Copy link
Collaborator

NimJay commented Oct 3, 2022

@mathieu-benoit that sounds like a good compromise for now.

Aside for Googlers that would like to contribute medium-large changes to this repository: please see this Google Doc.

@mathieu-benoit
Copy link
Contributor

mathieu-benoit commented Nov 29, 2022

Thanks @michaelact, @xiangshen-dk and @cc4i for your contributions. Like discussed, even if having Online Boutique on Cloud Run is a very good idea, we want to keep this repository specific to Kubernetes for now.

If anyone is interested in this, here are some implementations made about that for reference:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants