Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent parameter naming between batch and streaming fhir endpoint #131

Closed
williamito opened this issue Mar 8, 2021 · 0 comments · Fixed by #164
Closed

Inconsistent parameter naming between batch and streaming fhir endpoint #131

williamito opened this issue Mar 8, 2021 · 0 comments · Fixed by #164
Assignees

Comments

@williamito
Copy link
Collaborator

The FHIR endpoint parameter in Batch mode (serverFhirEndpoint) is named differently than in Streaming mode (openmrsfhirBaseEndpoint).

Here's a full comparison of the parameters that I found. I'm not sure if there should eventually be more parity for the Parquet settings.

Batch Streaming Comments
openmrsServerUrl openmrsServerUrl
openmrsUserName openmrsUserName
openmrsPassword openmrsPassword
serverFhirEndpoint openmrsfhirBaseEndpoint INCONSISTENT, binlog only
fhirSinkPath fhirSinkPath
sinkUserName sinkUserName
sinkPassword sinkPassword
fileParquetPath fileParquetPath
numParquetShards
secondsToFlushParquetFiles
rowGroupSizeForParquetFiles
searchList Different between FHIR Search and JDBC
batchSize
jdbcFetchSize
jdbcUrl
jdbcDriverClass
jdbcMaxPoolSize
dbUser
dbPassword
tableFhirMapPath
jdbcModeEnabled
fhirDebeziumConfigPath binlog only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants