New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if we need to make changes to support ForceFlush in batch processor #100
Check if we need to make changes to support ForceFlush in batch processor #100
Comments
TL;DR: Our Exporter makes the assumption that it will be offloading all spans into batches and exporting as a group. OpenTelemetry Exporters are not allowed to do this by specification (for some reason). This means that users of The only resolution here would be to "force flush" on every export call. Given this code is also used in the collector that gives me pause. Here's a proposed solution:
|
I think the collector should do batching using the exporter helper. IIRC it doesn't belong in our exporter here. |
Sure, I'll look at the exporter-helper batching in the collector and if I can migrate to that quickly, I will. However, I think the TL;DR: is that we'll have a long-term plan to remove the |
@jsuereth given that the upstream OT-Go release is still ~2 weeks away, could we consider spending the time to actually remove the |
At the timing of direct exporter implementation, the spec on batching wasn't fixed and I followed the design in OC exporter. I have no objection to remove |
See recent change open-telemetry/opentelemetry-go#1166 (issue: open-telemetry/opentelemetry-go#1072)
The text was updated successfully, but these errors were encountered: