Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove g.co.* labels from trace export. #711

Closed
dashpole opened this issue Aug 21, 2023 · 2 comments · Fixed by #715
Closed

Remove g.co.* labels from trace export. #711

dashpole opened this issue Aug 21, 2023 · 2 comments · Fixed by #715
Assignees
@dashpole
Labels
enhancement New feature or request priority: p3

Comments

@dashpole
Copy link
Contributor

dashpole commented Aug 21, 2023 •
edited
Loading

The new Cloud Trace UI uses OTel semantic conventions for service.name

We should remove our mapping for service.name to g.co/gae/app/module
@dashpole dashpole added enhancement New feature or request priority: p1 labels Aug 21, 2023
@dashpole dashpole self-assigned this Aug 23, 2023
@dashpole dashpole mentioned this issue Aug 23, 2023
Merged
@dashpole
Copy link
Contributor Author

Discussed with the team. This isn't super-high priority, so lowering to p2.

@dashpole
Copy link
Contributor Author

This only impacts the go exporter: https://github.com/search?q=org%3AGoogleCloudPlatform%20g.co%2Fgae%2Fapp%2Fmodule&type=code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dashpole dashpole

Labels
enhancement New feature or request priority: p3
Projects
None yet
Milestone
No milestone
1 participant
@dashpole